Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ssm - Rework (and enable) integration tests #1652

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 12, 2023

Depends-On: #558

SUMMARY

aws_ssm tests have been broken for a while. This should get initial integration tests up and running

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

Notes:

  • Does not cover cross-geo S3 buckets (only one region in CI at the minute)
  • Does not cover encrypted buckets (missing permissions)

@ansibullbot

This comment was marked as resolved.

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels Jan 12, 2023
@tremble tremble force-pushed the tests/connection_aws_ssm branch from 2954f25 to f6998ca Compare January 12, 2023 14:22
@tremble tremble removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 12, 2023
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the tests/connection_aws_ssm branch from f6998ca to db747be Compare January 12, 2023 14:50
@ansibullbot ansibullbot added integration tests/integration tests tests labels Jan 12, 2023
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble
Copy link
Contributor Author

tremble commented Jan 12, 2023

recheck

@softwarefactory-project-zuul

This comment was marked as outdated.

@markuman markuman added backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch labels Jan 12, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 5m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 47s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 14s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 33s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 55s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 31s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 17s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 57s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 24s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 01s
✔️ ansible-test-changelog SUCCESS in 2m 45s
✔️ ansible-test-splitter SUCCESS in 3m 21s
integration-community.aws-1 FAILURE in 40m 29s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble force-pushed the tests/connection_aws_ssm branch from ec2f252 to d63e710 Compare January 12, 2023 16:06
@tremble tremble force-pushed the tests/connection_aws_ssm branch from d63e710 to 18d40b0 Compare January 12, 2023 16:33
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 6m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 06s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 49s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 38s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 34s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 51s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 07s
✔️ ansible-test-changelog SUCCESS in 2m 45s
✔️ ansible-test-splitter SUCCESS in 2m 50s
✔️ integration-community.aws-1 SUCCESS in 13m 01s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 12, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 5m 28s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 37s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 12s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 47s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 04s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 45s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 46s
✔️ ansible-test-changelog SUCCESS in 2m 29s
✔️ ansible-test-splitter SUCCESS in 2m 42s
✔️ integration-community.aws-1 SUCCESS in 13m 01s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e01ac08 into ansible-collections:main Jan 12, 2023
@patchback
Copy link

patchback bot commented Jan 12, 2023

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/e01ac083262abc87f69d63d8ee7b2f93e06c3c43/pr-1652

Backported as #1655

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 12, 2023
aws_ssm - Rework (and enable) integration tests

Depends-On: #558
SUMMARY
aws_ssm tests have been broken for a while.  This should get initial integration tests up and running
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
Notes:

Does not cover cross-geo S3 buckets (only one region in CI at the minute)
Does not cover encrypted buckets (missing permissions)

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit e01ac08)
@patchback
Copy link

patchback bot commented Jan 12, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/e01ac083262abc87f69d63d8ee7b2f93e06c3c43/pr-1652

Backported as #1656

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 12, 2023
aws_ssm - Rework (and enable) integration tests

Depends-On: #558
SUMMARY
aws_ssm tests have been broken for a while.  This should get initial integration tests up and running
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
Notes:

Does not cover cross-geo S3 buckets (only one region in CI at the minute)
Does not cover encrypted buckets (missing permissions)

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit e01ac08)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 12, 2023
[PR #1652/e01ac083 backport][stable-5] aws_ssm - Rework (and enable) integration tests

This is a backport of PR #1652 as merged into main (e01ac08).
Depends-On: #558
SUMMARY
aws_ssm tests have been broken for a while.  This should get initial integration tests up and running
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
Notes:

Does not cover cross-geo S3 buckets (only one region in CI at the minute)
Does not cover encrypted buckets (missing permissions)

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 12, 2023
[PR #1652/e01ac083 backport][stable-4] aws_ssm - Rework (and enable) integration tests

This is a backport of PR #1652 as merged into main (e01ac08).
Depends-On: #558
SUMMARY
aws_ssm tests have been broken for a while.  This should get initial integration tests up and running
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
Notes:

Does not cover cross-geo S3 buckets (only one region in CI at the minute)
Does not cover encrypted buckets (missing permissions)

Reviewed-by: Markus Bergholz <[email protected]>
@tremble tremble deleted the tests/connection_aws_ssm branch February 15, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants