Skip to content

Commit

Permalink
aws_ssm - Rework (and enable) integration tests (#1652) (#1656)
Browse files Browse the repository at this point in the history
[PR #1652/e01ac083 backport][stable-5] aws_ssm - Rework (and enable) integration tests

This is a backport of PR #1652 as merged into main (e01ac08).
Depends-On: #558
SUMMARY
aws_ssm tests have been broken for a while.  This should get initial integration tests up and running
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
Notes:

Does not cover cross-geo S3 buckets (only one region in CI at the minute)
Does not cover encrypted buckets (missing permissions)

Reviewed-by: Markus Bergholz <[email protected]>
  • Loading branch information
patchback[bot] authored Jan 12, 2023
1 parent d1fd605 commit 7dc4f32
Show file tree
Hide file tree
Showing 48 changed files with 481 additions and 357 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/20230112-aws_ssm-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
trivial:
- aws_ssm - Rework and enable aws_ssm integration tests
1 change: 1 addition & 0 deletions tests/integration/targets/connection/aliases
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# Used to test basic operation once a connection plugin has established a connection
hidden
disabled
7 changes: 4 additions & 3 deletions tests/integration/targets/connection/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ set -eux

[ -f "${INVENTORY}" ]

# Run connection tests with both the default and C locale.
ansible-playbook test_connection.yml -i "${INVENTORY}" "$@"

ansible-playbook test_connection.yml -i "${INVENTORY}" "$@"
LC_ALL=C LANG=C ansible-playbook test_connection.yml -i "${INVENTORY}" "$@"
# Ansible 2.14 dropped support for non UTF-8 Locale
# https://github.com/ansible/ansible/pull/78175
# LC_ALL=C LANG=C ansible-playbook test_connection.yml -i "${INVENTORY}" "$@"
5 changes: 0 additions & 5 deletions tests/integration/targets/connection_aws_ssm/aliases

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion tests/integration/targets/connection_aws_ssm/meta/main.yml

This file was deleted.

4 changes: 4 additions & 0 deletions tests/integration/targets/connection_aws_ssm_amazon/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
time=10m

cloud/aws
connection_aws_ssm
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- hosts: localhost
roles:
- role: ../setup_connection_aws_ssm
vars:
target_os: amazon
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- hosts: localhost
tasks:
- include_role:
name: ../setup_connection_aws_ssm
tasks_from: cleanup.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependencies:
- connection
- setup_connection_aws_ssm
Loading

0 comments on commit 7dc4f32

Please sign in to comment.