Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1419/fad35892 backport][stable-5] Add ResourceType on ec2 snapshot copy #1605

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 25, 2022

This is a backport of PR #1419 as merged into main (fad3589).

SUMMARY

Fixes this issue that shows up when tags are specified:

An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_snapshot_copy

ADDITIONAL INFORMATION
# before

botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value                              
fatal: [localhost]: FAILED! => {                                                                                                                                                                   
    "boto3_version": "1.24.57",                                                                                                                                                                    
    "botocore_version": "1.27.58",                                                                                                                                                                 
    "changed": false,                                                                                                                                                                              
    "error": {                                                                                                                                                                                     
        "code": "InvalidParameterValue",                                                                                                                                                           
        "message": "Tag specification resource type must have a value"                                                                                                                             
    },  
....


# after  (no error message)

changed: [localhost] => {                                                                                                                                                                          
    "changed": true,                                                                                                                                                                               
    "invocation": {                                                                                                                                                                                
        "module_args": {       
.....

Add ResourceType on ec2 snapshot copy

SUMMARY
Fixes this issue that shows up when tags are specified:
An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_snapshot_copy
ADDITIONAL INFORMATION

# before

botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value
fatal: [localhost]: FAILED! => {
    "boto3_version": "1.24.57",
    "botocore_version": "1.27.58",
    "changed": false,
    "error": {
        "code": "InvalidParameterValue",
        "message": "Tag specification resource type must have a value"
    },
....

# after  (no error message)

changed: [localhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
.....

Reviewed-by: Mark Chappell <None>
Reviewed-by: Colby Shores <[email protected]>
Reviewed-by: None <None>
(cherry picked from commit fad3589)
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 5m 03s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 50s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 12s (non-voting)
ansible-test-sanity-docker-stable-2.12 POST_FAILURE in 10m 32s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 08s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 36s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 01s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 48s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 36s
✔️ ansible-test-changelog SUCCESS in 2m 10s
✔️ ansible-test-splitter SUCCESS in 2m 50s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Nov 25, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Nov 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 6m 27s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 20s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 41s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 40s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 12m 47s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 57s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 34s
✔️ ansible-test-changelog SUCCESS in 2m 13s
✔️ ansible-test-splitter SUCCESS in 2m 26s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6038fa9 into stable-5 Nov 25, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/fad358924d91150b6278a7832c2f2028d588bd44/pr-1419 branch November 25, 2022 12:48
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1605)

Update main branch after release 6.1.0 and 6.0.1

SUMMARY

Update main branch after release 6.1.0

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Helen Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants