Add ResourceType on ec2 snapshot copy (#1419)

Add ResourceType on ec2 snapshot copy

SUMMARY
Fixes this issue that shows up when tags are specified:
An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_snapshot_copy
ADDITIONAL INFORMATION



# before

botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value                              
fatal: [localhost]: FAILED! => {                                                                                                                                                                   
    "boto3_version": "1.24.57",                                                                                                                                                                    
    "botocore_version": "1.27.58",                                                                                                                                                                 
    "changed": false,                                                                                                                                                                              
    "error": {                                                                                                                                                                                     
        "code": "InvalidParameterValue",                                                                                                                                                           
        "message": "Tag specification resource type must have a value"                                                                                                                             
    },  
....


# after  (no error message)

changed: [localhost] => {                                                                                                                                                                          
    "changed": true,                                                                                                                                                                               
    "invocation": {                                                                                                                                                                                
        "module_args": {       
.....

Reviewed-by: Mark Chappell <None>
Reviewed-by: Colby Shores <[email protected]>
Reviewed-by: None <None>

changelogs/fragments/1419-fix-ec2_snapshot_copy-with-tags.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - ec2_snapshot_copy - including tags caused the erorr "Tag specification resource type must have a value". Fix sets the ResourceType to snapshot to resolve this issue (https://github.com/ansible-collections/community.aws/pull/1419).

plugins/modules/ec2_snapshot_copy.py

@@ -140,7 +140,7 @@ def copy_snapshot(module, ec2):
         params['KmsKeyId'] = module.params.get('kms_key_id')
 
     if module.params.get('tags'):
-        params['TagSpecifications'] = boto3_tag_specifications(module.params.get('tags'))
+        params['TagSpecifications'] = boto3_tag_specifications(module.params.get('tags'), types=['snapshot'])
 
     try:
         snapshot_id = ec2.copy_snapshot(**params)['SnapshotId']