[PR #1579/cea2ab5c backport][stable-4] Fix broken ec2_vpc_vgw tests #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Fix broken ec2_vpc_vgw tests SUMMARY The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed. Amazon's APIs used to be very slow to update this, making waiting for it a bad idea. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_vgw ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit cea2ab5)
tremble
approved these changes
Nov 2, 2022
ansibullbot
added
bug
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/cea2ab5cf7a8f778fe2fdf2bfa55fd3e0fba68de/pr-1579
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1579 as merged into main (cea2ab5).
SUMMARY
The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed.
Amazon's APIs used to be very slow to update this, making waiting for it a bad idea.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_vgw
ADDITIONAL INFORMATION