Fix broken ec2_vpc_vgw tests #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
tests/ec2_vpc_vgw
branch
from
afc22ba to
38f341f
Compare
markuman
approved these changes
Nov 2, 2022
markuman
added
backport-4
ansibullbot
added
bug
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1580 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fix broken ec2_vpc_vgw tests SUMMARY The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed. Amazon's APIs used to be very slow to update this, making waiting for it a bad idea. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_vgw ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit cea2ab5)
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1581 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fix broken ec2_vpc_vgw tests SUMMARY The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed. Amazon's APIs used to be very slow to update this, making waiting for it a bad idea. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_vgw ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit cea2ab5)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fix non-matching defaults in docs Depends-On: #1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
[PR #1579/cea2ab5c backport][stable-4] Fix broken ec2_vpc_vgw tests This is a backport of PR #1579 as merged into main (cea2ab5). SUMMARY The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed. Amazon's APIs used to be very slow to update this, making waiting for it a bad idea. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_vgw ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
[PR #1579/cea2ab5c backport][stable-5] Fix broken ec2_vpc_vgw tests This is a backport of PR #1579 as merged into main (cea2ab5). SUMMARY The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed. Amazon's APIs used to be very slow to update this, making waiting for it a bad idea. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_vgw ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
patchback bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fix non-matching defaults in docs Depends-On: #1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 15568f0)
patchback bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fix non-matching defaults in docs Depends-On: #1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 15568f0)
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/amazon.aws
that referenced
this pull request
Nov 2, 2022
Move RetryingBotoClientWrapper into module_utils.retries Depends-On: ansible-collections/community.aws#1579 SUMMARY Move RetryingBotoClientWrapper into module_utils.retries This means we can use it later with non-module plugins ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/modules.py plugins/module_utils/retries.py plugins/module_utils/waiters.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
[PR #1576/15568f01 backport][stable-5] Fix non-matching defaults in docs This is a backport of PR #1576 as merged into main (15568f0). Depends-On: #1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz <[email protected]>
tremble
pushed a commit
that referenced
this pull request
Feb 1, 2023
Fix non-matching defaults in docs Depends-On: #1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz (cherry picked from commit 15568f0) Co-authored-by: Felix Fontein
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Fix non-matching defaults in docs Depends-On: ansible-collections#1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@15568f0
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Fix non-matching defaults in docs Depends-On: ansible-collections#1579 SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME various Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@15568f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The APIs are no longer consistently returning deleted attachments. Accept both the attachment being listed but marked 'deleted', and not being listed.
Amazon's APIs used to be very slow to update this, making waiting for it a bad idea.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_vgw
ADDITIONAL INFORMATION