Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1405/e265ece5 backport][stable-4] acm_certificate - allow for a retry on the _info call after uploading a cert #1407

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 11, 2022

This is a backport of PR #1405 as merged into main (e265ece).

SUMMARY

We're sometimes hitting a race condition where we call _info before the APIs are ready to return details of the cert.
In a perfect world we'd add some waiters, but let's prevent unrelated failures when modifying amazon.aws module_utils first

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acm_certificate

ADDITIONAL INFORMATION

… a cert (#1405)

acm_certificate - allow for a retry on the _info call after uploading a cert

SUMMARY
We're sometimes hitting a race condition where we call _info before the APIs are ready to return details of the cert.
In a perfect world we'd add some waiters, but let's prevent unrelated failures when modifying amazon.aws module_utils first
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
acm_certificate
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit e265ece)
@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review tests tests labels Aug 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 4m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 29s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 32s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 41s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 06s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 01s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-community.aws-1 SUCCESS in 13m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 01s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 59s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 35s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 14s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-community.aws-1 SUCCESS in 10m 25s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cf7c4f9 into stable-4 Aug 11, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-4/e265ece597eb6a48269a7f5169f2a7561e9412d7/pr-1405 branch August 11, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants