acm_certificate - allow for a retry on the _info call after uploading a cert #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
alinabuzachis
approved these changes
Aug 11, 2022
tremble
added
mergeit
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1407 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
… a cert (#1405) acm_certificate - allow for a retry on the _info call after uploading a cert SUMMARY We're sometimes hitting a race condition where we call _info before the APIs are ready to return details of the cert. In a perfect world we'd add some waiters, but let's prevent unrelated failures when modifying amazon.aws module_utils first ISSUE TYPE Bugfix Pull Request COMPONENT NAME acm_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit e265ece)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
… a cert (#1405) (#1407) [PR #1405/e265ece5 backport][stable-4] acm_certificate - allow for a retry on the _info call after uploading a cert This is a backport of PR #1405 as merged into main (e265ece). SUMMARY We're sometimes hitting a race condition where we call _info before the APIs are ready to return details of the cert. In a perfect world we'd add some waiters, but let's prevent unrelated failures when modifying amazon.aws module_utils first ISSUE TYPE Bugfix Pull Request COMPONENT NAME acm_certificate ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We're sometimes hitting a race condition where we call _info before the APIs are ready to return details of the cert.
In a perfect world we'd add some waiters, but let's prevent unrelated failures when modifying amazon.aws module_utils first
ISSUE TYPE
COMPONENT NAME
acm_certificate
ADDITIONAL INFORMATION