[PR #1331/ed4165d6 backport][stable-4] ec2_vpc_vgw_info - update to not throw an error when run in check_mode #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
#1331) ec2_vpc_vgw_info - update to not throw an error when run in check_mode SUMMARY fixes: #137 ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_vgw_info.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> (cherry picked from commit ed4165d)
ansibullbot
added
community_review
feature
tremble
approved these changes
Jul 9, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jul 10, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/ed4165d6e34c5c33c751c8b138f24a058d1c2b6e/pr-1331
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ble-collections#1336) lambda_info and lambda_alias - avoid manipulating module.params SUMMARY Directly manipulating module.params results in the Ansible output incorrectly representing what was passed to the module, as such we shouldn't be doing this. Refactors lambda_alias to avoid passing around "module" entirely Updates lamba_info to avoid updating module.params ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_info lambda_alias ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1331 as merged into main (ed4165d).
SUMMARY
fixes: #137
ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all.
ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_vpc_vgw_info.py
ADDITIONAL INFORMATION