Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_vgw_info: check mode results in error. #137

Closed
resmo opened this issue Jul 14, 2020 · 2 comments · Fixed by #1331
Closed

ec2_vpc_vgw_info: check mode results in error. #137

resmo opened this issue Jul 14, 2020 · 2 comments · Fixed by #1331
Labels
affects_2.10 bug This issue/PR relates to a bug module module traceback

Comments

@resmo
Copy link
Member

resmo commented Jul 14, 2020 •
edited
Loading

SUMMARY

running check mode results in an error.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

ec2_vpc_vgw_info

ANSIBLE VERSION
2.9.10
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
ansible -m ec2_vpc_vgw_info --check localhost
EXPECTED RESULTS

no errors

ACTUAL RESULTS
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (DryRunOperation) when calling the DescribeVpnGateways operation: Request would have succeeded, but DryRun flag is set.
fatal: [...]: FAILED! => changed=false 
  msg: 'An error occurred (DryRunOperation) when calling the DescribeVpnGateways operation: Request would have succeeded, but DryRun flag is set.'
@tremble
Copy link
Contributor

tremble commented Jul 14, 2020

Vaguely related: #138

@ansibullbot
Copy link

cc @jillr @naslanidis @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug module module traceback labels Aug 19, 2020
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@tremble
module_utils.acm Remove unnecessary call to get_aws_connection_info (a…
27f991d 
…nsible-collections#137)

It's left over from a migration to AnsibleAWSModule
@tremble tremble mentioned this issue Jul 9, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jul 9, 2022
@tremble
ec2_vpc_vgw_info - update to not throw an error when run in check_mode (
ed4165d 
#1331)

ec2_vpc_vgw_info - update to not throw an error when run in check_mode

SUMMARY
fixes: #137
ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_vgw_info.py
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
patchback bot pushed a commit that referenced this issue Jul 9, 2022
@tremble @patchback
ec2_vpc_vgw_info - update to not throw an error when run in check_mode (
8e72bc2 
#1331)

ec2_vpc_vgw_info - update to not throw an error when run in check_mode

SUMMARY
fixes: #137
ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_vgw_info.py
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit ed4165d)
@patchback patchback bot mentioned this issue Jul 9, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jul 10, 2022
@patchback
ec2_vpc_vgw_info - update to not throw an error when run in check_mode (
7b447cf 
#1331) (#1336)

[PR #1331/ed4165d6 backport][stable-4] ec2_vpc_vgw_info - update to not throw an error when run in check_mode

This is a backport of PR #1331 as merged into main (ed4165d).
SUMMARY
fixes: #137
ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_vgw_info.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@renovate renovate bot mentioned this issue Aug 8, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects_2.10 bug This issue/PR relates to a bug module module traceback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec2_vpc_vgw_info - update to not throw an error when run in check_mode tremble/community.aws
3 participants
@resmo @tremble @ansibullbot