[PR #1212/bac24736 backport][stable-2] ecs_* - fix idempotence bug in ecs_service and dont require cluster
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…`` (#1212) ecs_* - fix idempotence bug in ecs_service and dont require ``cluster`` SUMMARY Don't require cluster param and use cluster name 'default' when not specified (see docs). Fix bug when comparing health_check_grace_period_seconds when not input by user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_service ecs_task ADDITIONAL INFORMATION Split up from #1209 to backport to stable-2 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit bac2473)
ansibullbot
added
bug
tremble
approved these changes
Jun 15, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-2/bac247365347a6b6e4f90c8087f235b01cf8d253/pr-1212
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…lections#1230) Move RetryingBotoClientWrapper into module_utils.retries Depends-On: ansible-collections#1579 SUMMARY Move RetryingBotoClientWrapper into module_utils.retries This means we can use it later with non-module plugins ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/modules.py plugins/module_utils/retries.py plugins/module_utils/waiters.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1212 as merged into main (bac2473).
SUMMARY
clusterparam and use cluster name 'default' when not specified (see docs).health_check_grace_period_secondswhen not input by user.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Split up from #1209 to backport to stable-2