Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging - ec2_snapshot_copy #1201

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 2, 2022

SUMMARY
  • Add the "resource_tags" alias, for consistency with other modules
  • minor docs clean-up
  • Use TagSpecification on creation rather than making a separate API call to tag the resource after creation.

Does not add purge_tags, since the module performs a one-shot action rather than managing the resources.

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

ec2_snapshot_copy

ADDITIONAL INFORMATION

Since we don't have a tags-only fragment, I've not switched this over to using a fragment. If I find more modules with a similar use-case I'll try to find a standard fragment we can use.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 03s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 08s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 29s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 04s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 56s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 32s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-community.aws-1 SUCCESS in 5m 28s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 12s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 40s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 06s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 17s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 01s
✔️ ansible-test-splitter SUCCESS in 2m 21s
✔️ integration-community.aws-1 SUCCESS in 7m 17s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a538562 into ansible-collections:main Jun 2, 2022
@tremble tremble deleted the tagging/cleanup/ec2_snapshot_copy branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…e-collections#1201)

route53_health_check: add support for enabling latency graphs

SUMMARY

Fixes ansible-collections#1189
Add support for enabling Latency graphs (MeasureLatency) during creation of a Route53 Health Check.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

route53_health_check
ADDITIONAL INFORMATION


You can't change the value of MeasureLatency after you create a health check.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Bikouo Aubin <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ble-collections#1222)

route53_health_check: bump up version_added for measure_latency

SUMMARY

With amazon.aws 5.1.0 release before merging ansible-collections#1201 , changing version_added for measure_latency to 5.2.0

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53_health_check

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants