Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_nacl - Add support for purge_tags #1189

Merged
merged 1 commit into from
Jun 2, 2022
Merged

ec2_vpc_nacl - Add support for purge_tags #1189

merged 1 commit into from
Jun 2, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 1, 2022 •
edited
Loading

SUMMARY
  • Add support to ec2_vpc_nacl for purge_tags
  • Use ec2 helper for tagging
  • Use TaggingSpecifications on creation
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_nacl

ADDITIONAL INFORMATION
  • Changelog
  • Integration tests

@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

cc @jillr @markuman @mmochan @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-galaxy-importer FAILURE in 4m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 58s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 36s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 11m 12s
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 12m 03s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 21s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 17s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 5m 45s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the tagging/purge/ec2_vpc_nacl branch from ac3d80f to e8e19c9 Compare June 1, 2022 18:49
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jun 1, 2022
@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels Jun 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 3m 45s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 01s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 39s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 50s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 47s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-splitter SUCCESS in 2m 46s
✔️ integration-community.aws-1 SUCCESS in 7m 58s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

jatorcasso
jatorcasso approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 4m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 44s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 32s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 35s
✔️ ansible-test-splitter SUCCESS in 2m 47s
✔️ integration-community.aws-1 SUCCESS in 7m 01s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit edc393e into ansible-collections:main Jun 2, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the tagging/purge/ec2_vpc_nacl branch July 7, 2022 19:23
@tremble tremble mentioned this pull request Jul 10, 2022
Closed
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@mandar242
route53_health_check: add support for enabling latency graphs (ansibl…
63cca2c 
…e-collections#1201)

route53_health_check: add support for enabling latency graphs

SUMMARY

Fixes ansible-collections#1189
Add support for enabling Latency graphs (MeasureLatency) during creation of a Route53 Health Check.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

route53_health_check
ADDITIONAL INFORMATION


You can't change the value of MeasureLatency after you create a health check.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Bikouo Aubin <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatorcasso jatorcasso jatorcasso approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @jatorcasso