-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecs_tag/efs_tag - add resource_tags as alias for tags #1184
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
minor_changes: | ||
- ecs_tag - ``resource_tags`` has been added as an alias for the ``tags`` parameter (https://github.com/ansible-collections/community.aws/pull/1184). | ||
- efs_tag - ``resource_tags`` has been added as an alias for the ``tags`` parameter (https://github.com/ansible-collections/community.aws/pull/1184). |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,7 @@ | |
- If the value provided for a tag is null and I(state=absent), the tag will be removed regardless of its current value. | ||
type: dict | ||
required: True | ||
aliases: ['resource_tags'] | ||
purge_tags: | ||
description: | ||
- Whether unspecified tags should be removed from the resource. | ||
|
@@ -124,7 +125,7 @@ def main(): | |
''' | ||
argument_spec = dict( | ||
resource=dict(required=True), | ||
tags=dict(type='dict', required=True), | ||
tags=dict(type='dict', required=True, aliases=['resource_tags']), | ||
purge_tags=dict(type='bool', default=False), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tremble Should't we uniform the default behaviour of purge_tags by defaulting to true even here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't sure. I wanted to get the "easy" bits in first, and was going to follow up with that later There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding the aliases was also something I can backport safely |
||
state=dict(default='present', choices=['present', 'absent']) | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.