ecs_tag/efs_tag - add resource_tags as alias for tags #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
alinabuzachis
approved these changes
Jun 1, 2022
| @@ -124,7 +125,7 @@ def main(): | |||
| ''' | |||
| argument_spec = dict( | |||
| resource=dict(required=True), | |||
| tags=dict(type='dict', required=True), | |||
| tags=dict(type='dict', required=True, aliases=['resource_tags']), | |||
| purge_tags=dict(type='bool', default=False), | |||
There was a problem hiding this comment.
@tremble Should't we uniform the default behaviour of purge_tags by defaulting to true even here?
There was a problem hiding this comment.
I wasn't sure. I wanted to get the "easy" bits in first, and was going to follow up with that later
There was a problem hiding this comment.
Adding the aliases was also something I can backport safely
| @@ -155,7 +156,7 @@ def main(): | |||
| argument_spec = dict( | |||
| cluster_name=dict(required=True), | |||
| resource=dict(required=False), | |||
| tags=dict(type='dict'), | |||
| tags=dict(type='dict', aliases=['resource_tags']), | |||
| purge_tags=dict(type='bool', default=False), | |||
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1191 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
ecs_tag/efs_tag - add resource_tags as alias for tags SUMMARY Cleanup related to the tagging fragment ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_tag efs_tag ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit f1e1d06)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
[PR #1184/f1e1d06f backport][stable-3] ecs_tag/efs_tag - add resource_tags as alias for tags This is a backport of PR #1184 as merged into main (f1e1d06). SUMMARY Cleanup related to the tagging fragment ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_tag efs_tag ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Cleanup related to the tagging fragment
ISSUE TYPE
COMPONENT NAME
ecs_tag
efs_tag
ADDITIONAL INFORMATION