azure_rm_sqldatabase: parse datetime module arguments #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests/sanity/ignore-2.10.txt:273:1: A100: Ignoring 'invalid-ansiblemodule-schema' on 'plugins/modules/azure_rm_sqldatabase.py' is unnecessary |
Removed, thanks! |
Same operation (tests/sanity/ignore-2.11.txt and tests/sanity/ignore-2.12.txt) |
This comment has been minimized.
This comment has been minimized.
Fred-sun
reviewed
Aug 31, 2021
| @@ -224,6 +224,7 @@ | |||
|
|
|||
| import time | |||
| from ansible_collections.azure.azcollection.plugins.module_utils.azure_rm_common import AzureRMModuleBase, format_resource_id | |||
| import dateutil.parser | |||
There was a problem hiding this comment.
Suggested change
| import dateutil.parser |
|
@nbr23 Can you add test cases for newly added logic? Thank you very much! |
Fred-sun
added
medium_priority
|
LGTM |
Fred-sun
added a commit
to Fred-sun/ansible_collections_azure
that referenced
this pull request
Mar 8, 2022
* azure_rm_sqldatabase: parse datetime module arguments (ansible-collections#623) * rm_sqldatabase: parse datetime arguments * Remove unused sanity test exception on rm_sqldatabase module schema * Remove unused sanity test exception on rm_sqldatabase module schema bis * sqldatabase: import dateutil in try/except * Add dateutil install to test suite * sqldatabase_info: Add earliest_restore_date value to returned facts * sqldatabase: add point in time restore test * Conditionally call non MSI auth when interacting with keyvault (ansible-collections#770) * Added the VM status detection mechanism (ansible-collections#772) * Set the parameter to a random number * Update storage account name Update azure_rm_virtualmachine vars add new change add new change 02 add new change 03 add new change 05 add new change 06 add new change 08 add new change09 update new Update new 02 Improve code logic * fix a typo error. related to ansible-collections#757 (ansible-collections#769) * fix a typo error. related to ansible-collections#757 * remove unused line Co-authored-by: Daniele Marcocci <[email protected]> * Update test region (ansible-collections#776) Co-authored-by: Max <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]>
xuzhang3
pushed a commit
that referenced
this pull request
Mar 8, 2022
* Ugrade azure-mgmt-compute SDK to track2 * fix small * Modify version from v2021-07-01 to v2020-04-01, no disk encryptions operation * Update small * fix azure_rm_diskencryption test fail * fix azure_rm_diskencryption test fail02 * fix sanity error * fix azure_rm_diskcryptionset test fail * fix azure_rm_virtualmachinescalesetinstance_info bug * fix azure_rm_virtualmachinescalesetinstance_info bug 02 * fix azure_rm_virtualmachien*extension test fail * Update azure_rm_virtualmachinescalesetinstance func paramter to vm_instance_i_ds * fix azure_rm_virtualmachinescalesetinstance test fail * fix sanity test fail * change exception type * fix azure_rm_hostgroup module * Update the code that throws the exception * Merge dev to local branch (#10) * azure_rm_sqldatabase: parse datetime module arguments (#623) * rm_sqldatabase: parse datetime arguments * Remove unused sanity test exception on rm_sqldatabase module schema * Remove unused sanity test exception on rm_sqldatabase module schema bis * sqldatabase: import dateutil in try/except * Add dateutil install to test suite * sqldatabase_info: Add earliest_restore_date value to returned facts * sqldatabase: add point in time restore test * Conditionally call non MSI auth when interacting with keyvault (#770) * Added the VM status detection mechanism (#772) * Set the parameter to a random number * Update storage account name Update azure_rm_virtualmachine vars add new change add new change 02 add new change 03 add new change 05 add new change 06 add new change 08 add new change09 update new Update new 02 Improve code logic * fix a typo error. related to #757 (#769) * fix a typo error. related to #757 * remove unused line Co-authored-by: Daniele Marcocci <[email protected]> * Update test region (#776) Co-authored-by: Max <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> * Revert "Merge dev to local branch (#10)" (#11) This reverts commit 1dce8f3. Co-authored-by: Max <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In
azure_rm_sqldatabase, the argumentsrestore_point_in_timeandsource_database_deletion_dateare dates.This bugfix parses the string passed as argument, and creates the datetime object required.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Currently the module expects
datetimeobjtects to be passed directly as module arguments from the playbook. However, it appears thatargument_specdoes not handledatetimeas an input type: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-specTo correct this, this fix changed the type of
restore_point_in_timeandsource_database_deletion_datetostr, and calls dateutil.parse on the string to get the datetime object expected by the azure sdk.This fixes #619