-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory Plugin #11
Inventory Plugin #11
Conversation
@willtome Thanks! Several concerns on my side.
|
@gavinfish currently there are not tests for this inventory plugin in Ansible core. Looking at how this is being done with AWS (https://github.com/ansible/ansible/tree/devel/test/integration/targets/inventory_aws_ec2) it should be a similar pattern to write for Azure assuming CI is set up the same. The plugin is documented in the code |
@willtome Yes, similar tests need to be done. I think a brief description to tell the difference of using origin azure inventory plugin and collection azure inventory plugin needs to be added in the readme. |
@willtome it seems the shippable job is stuck, please reset it before I can merge this PR. |
@gavinfish shippable looks like it has completed. I’m not sure what the other check is or how to change it. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
* Ugrade azure-mgmt-compute SDK to track2 * fix small * Modify version from v2021-07-01 to v2020-04-01, no disk encryptions operation * Update small * fix azure_rm_diskencryption test fail * fix azure_rm_diskencryption test fail02 * fix sanity error * fix azure_rm_diskcryptionset test fail * fix azure_rm_virtualmachinescalesetinstance_info bug * fix azure_rm_virtualmachinescalesetinstance_info bug 02 * fix azure_rm_virtualmachien*extension test fail * Update azure_rm_virtualmachinescalesetinstance func paramter to vm_instance_i_ds * fix azure_rm_virtualmachinescalesetinstance test fail * fix sanity test fail * change exception type * fix azure_rm_hostgroup module * Update the code that throws the exception * Merge dev to local branch (#10) * azure_rm_sqldatabase: parse datetime module arguments (#623) * rm_sqldatabase: parse datetime arguments * Remove unused sanity test exception on rm_sqldatabase module schema * Remove unused sanity test exception on rm_sqldatabase module schema bis * sqldatabase: import dateutil in try/except * Add dateutil install to test suite * sqldatabase_info: Add earliest_restore_date value to returned facts * sqldatabase: add point in time restore test * Conditionally call non MSI auth when interacting with keyvault (#770) * Added the VM status detection mechanism (#772) * Set the parameter to a random number * Update storage account name Update azure_rm_virtualmachine vars add new change add new change 02 add new change 03 add new change 05 add new change 06 add new change 08 add new change09 update new Update new 02 Improve code logic * fix a typo error. related to #757 (#769) * fix a typo error. related to #757 * remove unused line Co-authored-by: Daniele Marcocci <[email protected]> * Update test region (#776) Co-authored-by: Max <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> * Revert "Merge dev to local branch (#10)" (#11) This reverts commit 1dce8f3. Co-authored-by: Max <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]> Co-authored-by: Daniele Marcocci <[email protected]>
…p_availability Validate deployed app is available
Add inventory plugin from ansible/ansible to be distributed with collection