Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory Plugin #11

Merged
merged 6 commits into from
Dec 3, 2019
Merged

Inventory Plugin #11

merged 6 commits into from
Dec 3, 2019

Conversation

willtome
Copy link
Contributor

Add inventory plugin from ansible/ansible to be distributed with collection

@gavinfish
Copy link
Member

@willtome Thanks! Several concerns on my side.

  1. Any tests for this? How should an inventory plugin be tested in collection?
  2. Basic documentation is also necessary to tell users how to use this instead of the origin one.

@willtome
Copy link
Contributor Author

@gavinfish currently there are not tests for this inventory plugin in Ansible core. Looking at how this is being done with AWS (https://github.com/ansible/ansible/tree/devel/test/integration/targets/inventory_aws_ec2) it should be a similar pattern to write for Azure assuming CI is set up the same.

The plugin is documented in the code DOCUMENTATION section. This is used to generate the official documentation (https://docs.ansible.com/ansible/latest/plugins/inventory/azure_rm.html). I'm happy to add to the readme but do not want to duplicate the inherent documentation mechanism for plugins.

@gavinfish
Copy link
Member

@willtome Yes, similar tests need to be done.

I think a brief description to tell the difference of using origin azure inventory plugin and collection azure inventory plugin needs to be added in the readme.

@gavinfish
Copy link
Member

@willtome it seems the shippable job is stuck, please reset it before I can merge this PR.

@willtome
Copy link
Contributor Author

willtome commented Dec 2, 2019

@gavinfish shippable looks like it has completed. I’m not sure what the other check is or how to change it.

@gavinfish
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gavinfish gavinfish merged commit 91c3311 into ansible-collections:dev Dec 3, 2019
@willtome willtome deleted the inventory branch December 3, 2019 12:29
xuzhang3 pushed a commit that referenced this pull request Mar 8, 2022
* Ugrade azure-mgmt-compute SDK to track2

* fix small

* Modify version from v2021-07-01 to v2020-04-01, no disk encryptions operation

* Update small

* fix azure_rm_diskencryption test fail

* fix azure_rm_diskencryption test fail02

* fix sanity error

* fix azure_rm_diskcryptionset test fail

* fix azure_rm_virtualmachinescalesetinstance_info bug

* fix azure_rm_virtualmachinescalesetinstance_info bug 02

* fix azure_rm_virtualmachien*extension test fail

* Update azure_rm_virtualmachinescalesetinstance func paramter to vm_instance_i_ds

* fix azure_rm_virtualmachinescalesetinstance test fail

* fix sanity test fail

* change exception type

* fix azure_rm_hostgroup module

* Update the code that throws the exception

* Merge dev to local branch (#10)

* azure_rm_sqldatabase: parse datetime module arguments (#623)

* rm_sqldatabase: parse datetime arguments

* Remove unused sanity test exception on rm_sqldatabase module schema

* Remove unused sanity test exception on rm_sqldatabase module schema bis

* sqldatabase: import dateutil in try/except

* Add dateutil install to test suite

* sqldatabase_info: Add earliest_restore_date value to returned facts

* sqldatabase: add point in time restore test

* Conditionally call non MSI auth when interacting with keyvault (#770)

* Added the VM status detection mechanism (#772)

* Set the parameter to a random number

* Update storage account name

Update azure_rm_virtualmachine vars

add new change

add new change 02

add new change 03

add new change 05

add new change 06

add new change 08

add new change09

update new

Update new 02

Improve code logic

* fix a typo error. related to #757 (#769)

* fix a typo error. related to #757

* remove unused line

Co-authored-by: Daniele Marcocci <[email protected]>

* Update test region (#776)

Co-authored-by: Max <[email protected]>
Co-authored-by: Daniele Marcocci <[email protected]>
Co-authored-by: Daniele Marcocci <[email protected]>

* Revert "Merge dev to local branch (#10)" (#11)

This reverts commit 1dce8f3.

Co-authored-by: Max <[email protected]>
Co-authored-by: Daniele Marcocci <[email protected]>
Co-authored-by: Daniele Marcocci <[email protected]>
Yaish25491 pushed a commit to Yaish25491/azure-ansible-collection that referenced this pull request Jul 4, 2024
…p_availability

Validate deployed app is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants