ec2_instance : Add hibernation_options and volumes->ebs->encrypted keys #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
@GomathiselviS Thank you for working on this feature. Could you please add a changelog fragment and cover this functionality with integration tests?
GomathiselviS
changed the title
ansibullbot
added
community_review
integration
|
recheck |
gravesm
reviewed
Aug 22, 2022
tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/hibernation_options_config.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/hibernation_options_config.yml
Outdated
Show resolved
Hide resolved
|
recheck |
goneri
reviewed
Aug 23, 2022
|
recheck |
GomathiselviS
force-pushed
the
stop_hibernate_instance
branch
from
9b9af92 to
ff22f41
Compare
tests/integration/targets/ec2_instance_hibernation_options/main.yml
Outdated
Show resolved
Hide resolved
...ts/ec2_instance_hibernation_options/roles/ec2_instance_hibernation_options/defaults/main.yml
Outdated
Show resolved
Hide resolved
| description: | ||
| - Indicates whether an instance is enabled for hibernation. | ||
| Refer U(https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/hibernating-prerequisites.html) | ||
| for Hibernation prerequisits. |
There was a problem hiding this comment.
If this option requires a specific botocore version you should add a note here.
There was a problem hiding this comment.
This option is available in the latest and the versions we support.
gravesm
approved these changes
Sep 19, 2022
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
sns_topic - Add tags and purge_tags options SUMMARY sns_topic - Add tags and purge_tags options Closes ansible-collections#964 ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
sns_topic - Add tags and purge_tags options SUMMARY sns_topic - Add tags and purge_tags options Closes ansible-collections#964 ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
sns_topic - Add tags and purge_tags options SUMMARY sns_topic - Add tags and purge_tags options Closes ansible-collections#964 ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GomathiselviS [email protected]
SUMMARY
May Fix #969
In order to support Stop-hibernate behavior for an ec2 instance the following keys are added to the ec2_instance module
"hibernation_option": true
"volumes": [
{
],
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION