Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_instance enable hibernate option for instance_initiated_shutdown_behavior #969

Closed
1 task done
RonneGisun opened this issue Aug 15, 2022 · 6 comments · Fixed by #972
Closed
1 task done

ec2_instance enable hibernate option for instance_initiated_shutdown_behavior #969

RonneGisun opened this issue Aug 15, 2022 · 6 comments · Fixed by #972
Assignees
@GomathiselviS
Labels
feature This issue/PR relates to a feature request has_pr jira module module plugins plugin (any type)

Comments

@RonneGisun
Copy link

Summary

I am trying to launch new EC2 instances with the 'stop hibernate' option enabled, as per options available in AWS Console.
https://aws.amazon.com/about-aws/whats-new/2019/10/amazon-ec2-hibernation-now-available-on-windows/

Issue Type

Feature Idea

Component Name

ec2_instance

Additional Information

- name: start an instance with a hibernate_options
  amazon.aws.ec2_instance:
    name: "public-cpuoption-instance"
    vpc_subnet_id: subnet-5ca1ab1e
    tags:
      Environment: Testing
    instance_type: c4.large
    volumes:
    - device_name: /dev/sda1
      ebs:
        delete_on_termination: true
    cpu_options:
        core_count: 1
        threads_per_core: 1
    instance_initiated_shutdown_behavior: "stop_hibernate"

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @ryansb @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Aug 15, 2022
@alinabuzachis
Copy link
Collaborator

@RonneGisun Thank you for this feature idea. Would you be willing to work on this functionality and open a pull request?

@RonneGisun
Copy link
Author

@RonneGisun Thank you for this feature idea. Would you be willing to work on this functionality and open a pull request?

@alinabuzachis Sorry, but I couldn't justify spending time on this right now. I'm a team of one, and have a long to do list.

@GomathiselviS GomathiselviS self-assigned this Aug 18, 2022
@GomathiselviS GomathiselviS mentioned this issue Aug 22, 2022
Merged
@alinabuzachis
Copy link
Collaborator

@RonneGisun Could you please try this PR #972 and let us know if it addresses what you requested? Thanks.

@RonneGisun
Copy link
Author

@RonneGisun Could you please try this PR #972 and let us know if it addresses what you requested? Thanks.

@alinabuzachis Sorry I'm on holiday now, it might be sometime before I can get to this.

softwarefactory-project-zuul bot pushed a commit that referenced this issue Sep 20, 2022
@GomathiselviS
ec2_instance : Add hibernation_options and volumes->ebs->encrypted k…
7ca694f 
…eys (#972)

 ec2_instance : Add hibernation_options and volumes->ebs->encrypted keys

Signed-off-by: GomathiselviS [email protected]
SUMMARY


May Fix #969
In order to support Stop-hibernate behavior for an ec2 instance the following keys are added to the ec2_instance module
"hibernation_option": true
"volumes": [
{
                "ebs": {
                    "encrypted": true
                }
            }

],
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GomathiselviS GomathiselviS

Labels
feature This issue/PR relates to a feature request has_pr jira module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec2_instance : Add hibernation_options and volumes->ebs->encrypted keys GomathiselviS/amazon.aws
4 participants
@RonneGisun @alinabuzachis @GomathiselviS @ansibullbot