do not include {} boto filter by default #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When no filter: specified, do not include an empty dict in the list of boto filters because it effectively matches any host.
1 task
This comment has been minimized.
This comment has been minimized.
ansibullbot
added
has_issue
inventory
|
recheck |
ansibullbot
added
bug
|
recheck |
goneri
force-pushed
the
fix-include_filters
branch
from
515672e to
14cf380
Compare
1 task
|
recheck |
|
recheck |
1 similar comment
|
recheck |
tremble
approved these changes
Aug 31, 2021
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| bugfixes: | |||
| - "inventory - ``include_filters`` won't be ignored anymore if ``filters`` is not set (https://github.com/ansible-collections/amazon.aws/pull/456)." | |||
There was a problem hiding this comment.
Suggested change
| - "inventory - ``include_filters`` won't be ignored anymore if ``filters`` is not set (https://github.com/ansible-collections/amazon.aws/pull/456)." | |
| - "inventory - ``include_filters`` won't be ignored anymore if ``filters`` is not set (https://github.com/ansible-collections/amazon.aws/issues/457)." |
|
FTR, We've got a problem with the intermediate registry: ansible/ansible-zuul-jobs#1082 |
alinabuzachis
approved these changes
Aug 31, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Right now, we expect both requirement.txt / test-requirments.txt file in CI. Add this now allows us to get sanity jobs passing, then we can work on adding unit test requirements as needed. Signed-off-by: Paul Belanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #480
boto filters because it effectively matches any host.
Closes: #457
Closes: #452
ISSUE TYPE