Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_s3 copy to object #359

Merged
merged 5 commits into from
Jul 8, 2021
Merged

aws_s3 copy to object #359

merged 5 commits into from
Jul 8, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented May 6, 2021 •
edited by goneri
Loading

SUMMARY

add option to aws_s3 module to copy object existing on Amazon S3

Closes: #42

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_s3

ADDITIONAL INFORMATION
- name: copy from source to destination
  aws_s3:
      bucket: "{{ dest }}"
      mode: copy
      object: destination.txt
      copy_src:
        bucket: "{{ src }}"
        object: source.txt

@ansibullbot
Copy link

@abikouo this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request merge_commit This PR contains at least one merge commit. Please resolve! module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels May 21, 2021
@ansibullbot
Copy link

@abikouo this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label May 25, 2021
@ansibullbot
Copy link

@abikouo this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot
Copy link

cc @jillr @lwade @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review integration tests/integration plugins plugin (any type) tests tests and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels May 25, 2021
@goneri goneri mentioned this pull request May 25, 2021
Closed
@abikouo abikouo requested review from goneri, jillr and alinabuzachis May 26, 2021 07:04
@goneri
Copy link
Member

goneri commented May 27, 2021

recheck

@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Jun 7, 2021
@ansibullbot ansibullbot added community_review and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 1, 2021
@goneri
Copy link
Member

goneri commented Jul 2, 2021

recheck

@jillr jillr added the gate label Jul 7, 2021
@tremble tremble removed the gate label Jul 8, 2021
@tremble tremble closed this Jul 8, 2021
@tremble tremble reopened this Jul 8, 2021
@tremble tremble added gate and removed gate labels Jul 8, 2021
@tremble tremble dismissed alinabuzachis’s stale review July 8, 2021 11:11

out dated - 2 +ve cloud content team approvals added afterwards

@tremble tremble removed the gate label Jul 8, 2021
@tremble
Copy link
Contributor

tremble commented Jul 8, 2021

recheck

@tremble tremble added the gate label Jul 8, 2021
@tremble
Copy link
Contributor

tremble commented Jul 8, 2021

And finally, the gate tests seem to be running... Hopefully this will now get auto-merged by Zuul...

@ansible-zuul ansible-zuul bot merged commit 3591ca2 into ansible-collections:main Jul 8, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 16, 2021
@stefanhorning @alinabuzachis
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
0d1bc7a 
…ble-collections#359)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@73d60e5
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Jul 28, 2021
@stefanhorning @jillr
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
893f3b5 
…ble-collections#359)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@73d60e5
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Aug 20, 2021
@stefanhorning @jillr
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
cc13174 
…ble-collections#359)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@73d60e5
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Aug 26, 2021
@stefanhorning @jillr
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
b16969d 
…ble-collections#359)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@73d60e5
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Aug 27, 2021
@stefanhorning @jillr
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
ca88231 
…ble-collections#359)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@73d60e5
@Akasurde Akasurde mentioned this pull request Dec 29, 2021
Closed
1 task
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@stefanhorning
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
75143a6 
…ble-collections#359)
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@stefanhorning @abikouo
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
b432cc6 
…ble-collections#359)
@abikouo abikouo deleted the s3_copy_object branch October 24, 2023 15:44
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@stefanhorning
ec2_vpc_route_table: Don't fail if a route was already created. (ansi…
73d60e5 
…ble-collections#359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

@goneri goneri goneri approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request has_issue integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws_s3] Support copying s3://object-name to s3://object-new-name
6 participants
@abikouo @ansibullbot @goneri @tremble @jillr @alinabuzachis