Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws_s3] Support copying s3://object-name to s3://object-new-name #42

Closed
ElijahLynn opened this issue May 1, 2020 · 8 comments · Fixed by #359
Closed

[aws_s3] Support copying s3://object-name to s3://object-new-name #42

ElijahLynn opened this issue May 1, 2020 · 8 comments · Fixed by #359
Assignees
@abikouo
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@ElijahLynn
Copy link

SUMMARY

I am trying to use aws_s3 to copy one object already on the bucket to a new object.
I don't see anything in the docs suggesting that this is or is not possible.

ISSUE TYPE
  • Support remote bucket object copying
COMPONENT NAME

aws_s3

ADDITIONAL INFORMATION

N/A for now
@ElijahLynn ElijahLynn changed the title aws_s3 cp s3:// to s3:// aws_s3 support copying s3://object-name to s3://object-new-name May 1, 2020
@ElijahLynn ElijahLynn changed the title aws_s3 support copying s3://object-name to s3://object-new-name [aws_s3] Support copying s3://object-name to s3://object-new-name May 1, 2020
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ElijahLynn: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot
Copy link

cc @jillr @lwade @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added affects_2.10 module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage labels Aug 19, 2020
@ansibullbot ansibullbot added the plugins plugin (any type) label Aug 27, 2020
@goneri goneri added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_info This issue requires further information. Please answer any outstanding questions needs_triage labels Dec 4, 2020
@jillr
Copy link
Collaborator

jillr commented Dec 4, 2020

It looks like this would require implementing a new feature that uses boto's copy_object, which is not currently implemented by the module.

@jillr jillr added the feature This issue/PR relates to a feature request label Dec 4, 2020
@ansibullbot ansibullbot added the needs_info This issue requires further information. Please answer any outstanding questions label Jan 13, 2021
@abikouo abikouo mentioned this issue May 6, 2021
Merged
@goneri
Copy link
Member

goneri commented May 25, 2021

@ElijahLynn can you give a try to Aubin's PR? Feedbacks are welcome: #359

@ansibullbot
Copy link

@ElijahLynn This issue is waiting for your response. Please respond or the issue will be closed.

click here for bot help

@ElijahLynn
Copy link
Author

Responding to keep open. Need to test #359 still.

@abikouo abikouo removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly waiting_on_contributor Needs help. Feel free to engage to get things unblocked labels May 31, 2021
@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly waiting_on_contributor Needs help. Feel free to engage to get things unblocked labels May 31, 2021
@abikouo abikouo removed the needs_info This issue requires further information. Please answer any outstanding questions label Jul 1, 2021
@abikouo abikouo removed needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly waiting_on_contributor Needs help. Feel free to engage to get things unblocked labels Jul 1, 2021
@ansibullbot
Copy link

cc @linabuzachis
click here for bot help

@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly waiting_on_contributor Needs help. Feel free to engage to get things unblocked labels Jul 1, 2021
ansible-zuul bot pushed a commit that referenced this issue Jul 8, 2021
@abikouo
aws_s3 copy to object (#359)
3591ca2 
``aws_s3`` copy to object

SUMMARY

add option to aws_s3 module to copy object existing on Amazon S3

Closes: #42
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_s3
ADDITIONAL INFORMATION



- name: copy from source to destination
  aws_s3:
      bucket: "{{ dest }}"
      mode: copy
      object: destination.txt
      copy_src:
        bucket: "{{ src }}"
        object: source.txt

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@tremble @jillr
Initial tests for kinesis_stream (ansible-collections#42)
388976f 
* Initial tests for kinesis_stream

* Add exceptions for broken check_mode behaviour (idemmpotency)

* kinesis_stream requires shards to be defined, update the docs to match

* Add tests for tagging and retention period

* Yet more tests (and bugs)

* Disable Kinesis KMS tests - not supported in CI right now

* Apply minor changes from review

Co-authored-by: Jill R <[email protected]>

Co-authored-by: Jill R <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@tremble @jillr @abikouo
Initial tests for kinesis_stream (ansible-collections#42)
472b201 
* Initial tests for kinesis_stream

* Add exceptions for broken check_mode behaviour (idemmpotency)

* kinesis_stream requires shards to be defined, update the docs to match

* Add tests for tagging and retention period

* Yet more tests (and bugs)

* Disable Kinesis KMS tests - not supported in CI right now

* Apply minor changes from review

Co-authored-by: Jill R <[email protected]>

Co-authored-by: Jill R <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@tremble @jillr
Initial tests for kinesis_stream (ansible-collections#42)
05dc527 
* Initial tests for kinesis_stream

* Add exceptions for broken check_mode behaviour (idemmpotency)

* kinesis_stream requires shards to be defined, update the docs to match

* Add tests for tagging and retention period

* Yet more tests (and bugs)

* Disable Kinesis KMS tests - not supported in CI right now

* Apply minor changes from review

Co-authored-by: Jill R <[email protected]>

Co-authored-by: Jill R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abikouo abikouo

Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aws_s3 copy to object abikouo/amazon.aws
5 participants
@goneri @ElijahLynn @jillr @ansibullbot @abikouo