Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudformation - use standard retry decorator pattern #358

Merged
merged 2 commits into from
May 21, 2021
Merged

cloudformation - use standard retry decorator pattern #358

merged 2 commits into from
May 21, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 5, 2021 •
edited by goneri
Loading

Depends-On: ansible/ansible-zuul-jobs#944

SUMMARY

The cloudformation module was explicitly applying the retry decorator to functions rather than using our standard client wrapper.

PR switches to our standard pattern for consistency.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudformation

ADDITIONAL INFORMATION

@tremble tremble force-pushed the awsretry/cloudformation branch from 5ad67c0 to b9ab289 Compare May 15, 2021 12:11
@tremble
Copy link
Contributor Author

tremble commented May 15, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator

jillr commented May 19, 2021

recheck

@jillr
Copy link
Collaborator

jillr commented May 19, 2021

I'm running ansible-test integration --diff --no-temp-workdir --skip-tags False --continue-on-error --python 3.6 -vvvv locally and it kicked off tests, trying a recheck?

@tremble
Copy link
Contributor Author

tremble commented May 19, 2021

@jillr I've tried multiple rechecks, and other PRs are also skipping the integration tests. (for example #365)

@tremble tremble force-pushed the awsretry/cloudformation branch from b9ab289 to 4d21b87 Compare May 20, 2021 18:49
jillr
jillr approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the integration tests locally so the CI issue doesn't block merging. Will gate if/when that passes.

@jillr jillr added the gate label May 20, 2021
@goneri goneri removed the gate label May 20, 2021
@goneri
Copy link
Member

goneri commented May 20, 2021

recheck

@goneri goneri closed this May 20, 2021
@goneri goneri reopened this May 20, 2021
@tremble tremble added the gate label May 20, 2021
@tremble
Copy link
Contributor Author

tremble commented May 21, 2021

recheck

@ansible-zuul ansible-zuul bot merged commit cf39a04 into ansible-collections:main May 21, 2021
@tremble tremble deleted the awsretry/cloudformation branch May 28, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @jillr @goneri