-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utils for ec2_transit_gateway_* #2325
Merged
softwarefactory-project-zuul
merged 9 commits into
ansible-collections:main
from
mandar242:ec2_utils_10_07
Oct 23, 2024
Merged
Add utils for ec2_transit_gateway_* #2325
softwarefactory-project-zuul
merged 9 commits into
ansible-collections:main
from
mandar242:ec2_utils_10_07
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandar242
changed the title
Add ec2 transit gateway api calls to module_utils/ec2
Add utils for ec2_transit_gateway_*
Oct 8, 2024
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
ec2_utils_10_07
branch
from
October 10, 2024 18:06
53455f6
to
bfcac83
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
ec2_utils_10_07
branch
from
October 11, 2024 21:38
bfcac83
to
c105cff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
ec2_utils_10_07
branch
from
October 16, 2024 01:09
40212c1
to
3f91df5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
abikouo
previously requested changes
Oct 16, 2024
mandar242
force-pushed
the
ec2_utils_10_07
branch
from
October 17, 2024 20:03
3f91df5
to
a667af2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please ensure that linters are green and tests pass?
alinabuzachis
approved these changes
Oct 21, 2024
GomathiselviS
approved these changes
Oct 22, 2024
regate |
GomathiselviS
added
mergeit
Merge the PR (SoftwareFactory)
and removed
mergeit
Merge the PR (SoftwareFactory)
labels
Oct 22, 2024
@mandar242 Can you please rebase? |
mandar242
force-pushed
the
ec2_utils_10_07
branch
from
October 22, 2024 19:07
a7f99ab
to
570738c
Compare
regate |
regate |
softwarefactory-project-zuul
bot
merged commit Oct 23, 2024
2b0bf35
into
ansible-collections:main
35 of 36 checks passed
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
alinabuzachis
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fc782d2
alinabuzachis
pushed a commit
to mandar242/community.aws
that referenced
this pull request
Oct 25, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
alinabuzachis
pushed a commit
to GomathiselviS/community.aws
that referenced
this pull request
Oct 25, 2024
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added api calls used by ec2_transit_gateway and ec2_transit_gateway_info to ec2 module_utils
Required for ansible-collections/community.aws#2158
ISSUE TYPE
COMPONENT NAME
module_utils/ec2
ADDITIONAL INFORMATION