Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ec2_vpc_net* modules #2158

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 1, 2024

SUMMARY

Refactor ec2_vpc_net and ec2_vpc_net_info modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • ec2_vpc_net
  • ec2_vpc_net_info

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/505ca32424474c6eb24f417336d7394d

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 12m 47s
✔️ ansible-test-splitter SUCCESS in 5m 01s
✔️ integration-amazon.aws-1 SUCCESS in 7m 12s
Skipped 43 jobs

plugins/modules/ec2_vpc_net.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_net_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_net.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_net.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor_ec2_vpc_net_2401071331 branch from 32a45f7 to e03c3aa Compare July 4, 2024 15:49
@abikouo abikouo requested a review from alinabuzachis July 4, 2024 15:50
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a83426e88fa447288b6c0038c43ca176

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 12m 29s
✔️ ansible-test-splitter SUCCESS in 4m 57s
integration-amazon.aws-1 FAILURE in 7m 21s
Skipped 43 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b2a82d297321465e940b7656110c79e5

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 12m 25s
✔️ ansible-test-splitter SUCCESS in 5m 08s
integration-amazon.aws-1 FAILURE in 4m 57s
Skipped 43 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/482c2abe80d24b06b095c53b7e50d982

✔️ ansible-galaxy-importer SUCCESS in 4m 51s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 7m 37s
Skipped 43 jobs

Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment in line, but this looks good!

plugins/modules/ec2_vpc_net.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor_ec2_vpc_net_2401071331 branch from 55e478a to e5d1486 Compare July 8, 2024 10:01
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/bf22832cddcf485d81e000c530a8946b

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 12m 39s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-amazon.aws-1 SUCCESS in 8m 38s
Skipped 43 jobs

@abikouo abikouo force-pushed the refactor_ec2_vpc_net_2401071331 branch from e5d1486 to 790add3 Compare July 8, 2024 11:56
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1bb660a31799453fa3ae5024ee25d68b

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 7m 05s
Skipped 43 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 8, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0c44a298a29b4e3a9b9b472d9e8178b0

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-amazon.aws-1 SUCCESS in 8m 23s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fb67bd6 into ansible-collections:main Jul 8, 2024
35 of 37 checks passed
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
mandar242 added a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY

Refactor ec2_transit_gateway and ec2_transit_gateway_info modules

common code moved to module_utils ansible-collections#2325
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@fc782d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants