module_utils/ec2 - Move shared code for Launch template AWS API calls #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
ec2_utils_0930
branch
from
230ce86 to
59cbd8d
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
recheck |
There was a problem hiding this comment.
@abikouo Can you please break up this PR into different ones?
All modifications on this PR are related this is to prepare the promotion of the |
abikouo
force-pushed
the
ec2_utils_0930
branch
from
5273045 to
0118a69
Compare
tremble
previously requested changes
Oct 7, 2024
abikouo
force-pushed
the
ec2_utils_0930
branch
from
0118a69 to
4752320
Compare
|
recheck |
|
recheck |
abikouo
force-pushed
the
ec2_utils_0930
branch
from
1eb7b3f to
c5916bb
Compare
abikouo
force-pushed
the
ec2_utils_0930
branch
from
c5916bb to
4e3d449
Compare
alinabuzachis
approved these changes
Oct 15, 2024
GomathiselviS
approved these changes
Oct 15, 2024
abikouo
force-pushed
the
ec2_utils_0930
branch
from
25a2141 to
33da9e5
Compare
softwarefactory-project-zuul
bot
merged commit 3600745
into
ansible-collections:main
36 of 37 checks passed
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Oct 18, 2024
SUMMARY Depends-On: ansible-collections/amazon.aws#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes #176) Add the possibility to tag specific resources, not always instance and volume (Closes [#48](#48, Closes #2083) Support EBS Throughput (Closes #1944) Fix issue occurring when launch template contains more than 200 versions (Closes #2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
abikouo
added a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 18, 2024
…#2164) SUMMARY Depends-On: ansible-collections#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes ansible-collections#176) Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083) Support EBS Throughput (Closes ansible-collections#1944) Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@40d61f0
alinabuzachis
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2024
…#2164) SUMMARY Depends-On: ansible-collections/amazon.aws#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes ansible-collections#176) Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083) Support EBS Throughput (Closes ansible-collections#1944) Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
alinabuzachis
pushed a commit
to GomathiselviS/community.aws
that referenced
this pull request
Oct 25, 2024
…#2164) SUMMARY Depends-On: ansible-collections/amazon.aws#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes ansible-collections#176) Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083) Support EBS Throughput (Closes ansible-collections#1944) Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
community.aws.ec2_launch_templateinto module_utils/ec2determine_iam_rolefrom modulesamazon.aws.ec2_instanceandcommunity.aws.ec2_launch_templateec2_launch_template_infoISSUE TYPE