backup_plan_info: bugfix to enable getting info of all backup plans #2083
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 42s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 26s |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 04s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
46a0ad8 to
8b8c179
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 02s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
8b8c179 to
3d80e06
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 42s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 21s |
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| bugfixes: | |||
There was a problem hiding this comment.
I don't know if this is a bugfix. This feature was not working because it was not implemented and the module does not say it supports listing all backup plans (that's why backup_plan_names was a required parameter). To me it is probably minor_changes, a new functionality. You should also document that when O(backup_plan_names) is omitted the module gathers information about all backup plans.
There was a problem hiding this comment.
I added it as a bugfix because the existing module code documentation had an example to do this
but example was not working
https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/backup_plan_info.py#L33-L35
@alinabuzachis
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
3d2be8c to
903fbc2
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 24s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
903fbc2 to
6105909
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 06s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
6105909 to
49f1d29
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 15s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
49f1d29 to
bbea251
Compare
|
Build failed. ❌ ansible-galaxy-importer POST_FAILURE in 13m 56s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
bbea251 to
5fe9feb
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 53s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
5fe9feb to
04f2386
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 40s |
mandar242
force-pushed
the
backup_plan_list_all_fix
branch
from
04f2386 to
cf3c3fc
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 49s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 42s |
softwarefactory-project-zuul
bot
merged commit 9c53b6c
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2121 🤖 @patchback |
…2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working # Gather information about all backup plans - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell (cherry picked from commit 9c53b6c)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2122 🤖 @patchback |
…2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working # Gather information about all backup plans - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell (cherry picked from commit 9c53b6c)
…2083) (#2122) [PR #2083/9c53b6c1 backport][stable-8] backup_plan_info: bugfix to enable getting info of all backup plans This is a backport of PR #2083 as merged into main (9c53b6c). SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working # Gather information about all backup plans - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION
…2083) (#2121) [PR #2083/9c53b6c1 backport][stable-7] backup_plan_info: bugfix to enable getting info of all backup plans This is a backport of PR #2083 as merged into main (9c53b6c). SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working # Gather information about all backup plans - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…nsible-collections#2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell
…nsible-collections#2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell
…nsible-collections#2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell
…nsible-collections#2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell
…nsible-collections#2083) backup_plan_info: bugfix to enable getting info of all backup plans SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working # Gather information about all backup plans - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Chappell
…#2164) SUMMARY Depends-On: ansible-collections#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes ansible-collections#176) Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083) Support EBS Throughput (Closes ansible-collections#1944) Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@40d61f0
SUMMARY
Fix being unable to fetch info of all backup plans.
With
backup_plan_namesbeing a required parameter, the functionality to get all plans info was not workingISSUE TYPE
COMPONENT NAME
backup_plan_info
ADDITIONAL INFORMATION