fix: remove default value for accelerate_enabled variable

[rvalab]

SUMMARY

Remove default value for accelerate_enabled variable.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

amazon.aws.s3_bucket

ADDITIONAL INFORMATION

Starting version 8.1.0, module execution failed on NetApp StorageGRID systems.

...
TASK [Create Bucket and Apply Bucket Policy] ************************************************************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (XNotImplemented) when calling the GetBucketAccelerateConfiguration operation: The request you provided implies functionality that is not implemented.
fatal: [localhost]: FAILED! => {"boto3_version": "1.34.154", "botocore_version": "1.34.154", "changed": false, "error": {"code": "XNotImplemented", "message": "The request you provided implies functionality that is not implemented.", "resource": "/my-bucket?accelerate"}, "msg": "Fetching bucket transfer acceleration state is not supported: An error occurred (XNotImplemented) when calling the GetBucketAccelerateConfiguration operation: The request you provided implies functionality that is not implemented.", "response_metadata": {"host_id": "12329880", "http_headers": {"connection": "CLOSE", "content-length": "253", "content-type": "application/xml", "date": "Tue, 06 Aug 2024 11:51:52 GMT", "server": "StorageGRID/11.8.0.5", "x-amz-id-2": "12329880", "x-amz-request-id": "1722945112091352", "x-ntap-sg-trace-id": "53350fe8388e570f"}, "http_status_code": 501, "request_id": "1722945112091352", "retry_attempts": 0}}
...

This is because there is a default value set to accelerate_enabled variable.
With this default value, condition in line 956 (if accelerate_enabled is not None:) is always true and the module failed even if the functionality is not implemented in StorageGRID systems.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/29a8776e2ae140e1bd8e33441bec7778

✔️ ansible-galaxy-importer SUCCESS in 4m 50s
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-splitter SUCCESS in 4m 19s
✔️ integration-amazon.aws-1 SUCCESS in 6m 59s
Skipped 43 jobs

[alinabuzachis]

@rvalab Does this PR #2194 solve your issue or your patch is still needed?

[rvalab]

@alinabuzachis #2194 not but #2222 fixed my issue.

[tremble]

@rvalab many thanks for taking the time to submit this PR.

I'm sorry I missed your PR when submitting mine: I saw #2220 come through and knew what the issue would be and totally missed that you'd already started on a fix. If you take a look at #2222 you can see there are a couple of extra steps that would have been needed on this PR:

• A changelog fragment
• The docs needed to be updated

Additionally, the set/unset code should generally check for "None" (which unfortunately didn't happen with the original PR), and not automatically disable things which may have been manually set while the module didn't support them.