Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.1.0 fails with custom s3 provider (transfer acceleration feature) #2220

Closed
1 task done
johansenha opened this issue Aug 19, 2024 · 1 comment · Fixed by #2222
Closed
1 task done

8.1.0 fails with custom s3 provider (transfer acceleration feature) #2220

johansenha opened this issue Aug 19, 2024 · 1 comment · Fixed by #2222

Comments

@johansenha
Copy link

johansenha commented Aug 19, 2024

Summary

Since 8.1.0 s3_bucket module calls fail with an error even when transfer acceleration is set to false.
We are not using Amazon AWS S3 as endpoint but a custom one on-premises.

With 8.0.1 it's working without issues.

s3_bucket - Add support for enabling Amazon S3 Transfer Acceleration by setting the accelerate_enabled option (#2046).

Issue Type

Bug Report

Component Name

s3_bucket

Ansible Version

$ ansible --version

ansible [core 2.17.1]
  config file = /Users/user.name/git/ansible.cfg
  configured module search path = ['/usr/local/lib/python3.8/dist-packages/ansible/modules']
  ansible python module location = /opt/homebrew/Cellar/ansible/10.1.0/libexec/lib/python3.12/site-packages/ansible
  ansible collection location = /Users/user.name/git/collections:/Users/user.name/.ansible/collections:/usr/share/ansible/collections
  executable location = /opt/homebrew/bin/ansible
  python version = 3.12.5 (main, Aug  6 2024, 19:08:49) [Clang 15.0.0 (clang-1500.3.9.4)] (/opt/homebrew/Cellar/ansible/10.1.0/libexec/bin/python)
  jinja version = 3.1.4
  libyaml = True

Collection Versions

$ ansible-galaxy collection list

Collection                               Version
---------------------------------------- -------
amazon.aws                               8.1.0 

AWS SDK versions

$ pip show boto boto3 botocore

Name: boto3
Version: 1.34.43

Name: botocore
Version: 1.34.43

Configuration

$ ansible-config dump --only-changed
Std configuration

OS / Environment

Ubuntu

Steps to Reproduce

- name: Create a bucket per customer
  amazon.aws.s3_bucket:
    endpoint_url: "https://{{ s3_endpoint_url }}"
    aws_access_key: "{{ s3_usage_accesskey }}"
    aws_secret_key: "{{ s3_usage_secretkey }}"
    name: "{{ item.name | lower }}"
    state: present
    tags:
      Owner: "{{ item.email }}"
  loop: "{{ customers }}"

Expected Results

Bucket should be created

Actual Results

  msg: 'Fetching bucket transfer acceleration state is not supported: An error occurred (NotImplemented) when calling the GetBucketAccelerateConfiguration operation: A header you provided implies functionality that is not implemented.'
  response_metadata:
    http_headers:
      connection: keep-alive
      content-length: '275'
      content-type: application/xml
      date: Mon, 19 Aug 2024 08:21:58 GMT
      server: S3
      strict-transport-security: max-age=31536000
      x-content-type-options: nosniff
      x-gmt-error-code: NotImplemented
      x-gmt-message: A header you provided implies functionality that is not implemented.
    http_status_code: 501
    retry_attempts: 0

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@johansenha johansenha changed the title 8.1.0 fails with customer s3 provider (transfer acceleration feature) 8.1.0 fails with custom s3 provider (transfer acceleration feature) Aug 19, 2024
patchback bot pushed a commit that referenced this issue Aug 21, 2024
SUMMARY
fixes #2220
Removes the default for accelerate_enabled:

having the default explicitly set to false breaks idempotency when only passed partial configuration
having the default explicitly set results in the module always failing on non-AWS platforms

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 0dbac7a)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Aug 21, 2024
This is a backport of PR #2222 as merged into main (0dbac7a).
SUMMARY
fixes #2220
Removes the default for accelerate_enabled:

having the default explicitly set to false breaks idempotency when only passed partial configuration
having the default explicitly set results in the module always failing on non-AWS platforms

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@tremble
Copy link
Contributor

tremble commented Aug 22, 2024

Hi @johansenha,

We've merged a change which should fix this issue and be available with the next 8.x release. Hopefully this will be available early in September.

braydencw1 pushed a commit to braydencw1/amazon.aws that referenced this issue Aug 29, 2024
…s#2222)

SUMMARY
fixes ansible-collections#2220
Removes the default for accelerate_enabled:

having the default explicitly set to false breaks idempotency when only passed partial configuration
having the default explicitly set results in the module always failing on non-AWS platforms

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants