Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rds_param_group to rds_instance_param_group #2058

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/20240516-rds_param_group.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
deprecated_features:
- rds_param_group - the ``rds_param_group`` module has been renamed to ``rds_instance_param_group``.
The usage of the module has not changed. The rds_param_group alias will be removed in version 10.0.0 (https://github.com/ansible-collections/amazon.aws/pull/2058).
8 changes: 8 additions & 0 deletions meta/runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ action_groups:
- rds_cluster_snapshot
- rds_instance
- rds_instance_info
- rds_instance_param_group
- rds_instance_snapshot
- rds_option_group
- rds_option_group_info
Expand Down Expand Up @@ -155,6 +156,13 @@ plugin_routing:
execute_lambda:
# Deprecation for this alias should not *start* prior to 2024-09-01
redirect: amazon.aws.lambda_execute
rds_param_group:
redirect: amazon.aws.rds_instance_param_group
deprecation:
removal_version: 10.0.0
warning_text: >-
rds_param_group has been renamed to rds_instance_param_group.
Please update your tasks.
lookup:
aws_ssm:
# Deprecation for this alias should not *start* prior to 2024-09-01
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

DOCUMENTATION = r"""
---
module: rds_param_group
module: rds_instance_param_group
version_added: 5.0.0
short_description: manage RDS parameter groups
description:
Expand Down Expand Up @@ -61,7 +61,7 @@

EXAMPLES = r"""
- name: Add or change a parameter group, in this case setting auto_increment_increment to 42 * 1024
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
state: present
name: norwegian-blue
description: 'My Fancy Ex Parrot Group'
Expand All @@ -73,7 +73,7 @@
Application: parrot

- name: Remove a parameter group
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
state: absent
name: norwegian-blue
"""
Expand Down
56 changes: 28 additions & 28 deletions tests/integration/targets/rds_param_group/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
block:
# ============================================================
- name: test empty parameter group - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -36,7 +36,7 @@
- result.changed

- name: test empty parameter group
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -54,7 +54,7 @@

# ============================================================
- name: test empty parameter group with no arguments changes nothing - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -68,7 +68,7 @@
- not result.changed

- name: test empty parameter group with no arguments changes nothing
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -82,7 +82,7 @@

# ============================================================
- name: test adding numeric tag - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -98,7 +98,7 @@
that:
- result.changed
- name: test adding numeric tag
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -123,7 +123,7 @@
# ============================================================

- name: test modifying rds parameter group engine/family (warning displayed)
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine_to_modify_to }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -143,7 +143,7 @@

# ============================================================
- name: test tagging existing group - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -160,7 +160,7 @@
that:
- result.changed
- name: test tagging existing group
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -186,7 +186,7 @@

# ============================================================
- name: test repeating tagging existing group - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -212,7 +212,7 @@
- result.tags["NewTag"] == 'hello'

- name: test repeating tagging existing group
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -238,7 +238,7 @@

# ============================================================
- name: test deleting tags from existing group - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -254,7 +254,7 @@
that:
- result.changed
- name: test deleting tags from existing group
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -277,7 +277,7 @@

# ============================================================
- name: test state=absent with engine defined (expect changed=true) - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
state: absent
Expand All @@ -290,7 +290,7 @@
- result.changed

- name: test state=absent with engine defined (expect changed=true)
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
state: absent
Expand All @@ -303,7 +303,7 @@

# ============================================================
- name: test creating group with parameters - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -325,7 +325,7 @@
- result.changed

- name: test creating group with parameters
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand Down Expand Up @@ -355,7 +355,7 @@

# ============================================================
- name: test repeating group with parameters - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -377,7 +377,7 @@
- not result.changed

- name: test repeating group with parameters
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand Down Expand Up @@ -407,7 +407,7 @@

# ============================================================
- name: test state=absent with engine defined (expect changed=true) - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
state: absent
Expand All @@ -419,7 +419,7 @@
that:
- result.changed
- name: test state=absent with engine defined (expect changed=true)
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
state: absent
Expand All @@ -432,7 +432,7 @@

# ============================================================
- name: test repeating state=absent (expect changed=false) - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
state: absent
Expand All @@ -445,7 +445,7 @@
that:
- not result.changed
- name: test repeating state=absent (expect changed=false)
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
state: absent
Expand All @@ -459,7 +459,7 @@

# ============================================================
- name: test creating group with more than 20 parameters - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -473,7 +473,7 @@
that:
- result.changed
- name: test creating group with more than 20 parameters
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -488,7 +488,7 @@

# ============================================================
- name: test creating group with more than 20 parameters - CHECK_MODE
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -502,7 +502,7 @@
that:
- not result.changed
- name: test creating group with more than 20 parameters
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
engine: "{{ rds_param_group.engine }}"
description: "{{ rds_param_group.description }}"
Expand All @@ -518,7 +518,7 @@
always:
# ============================================================
- name: test state=absent (expect changed=false)
amazon.aws.rds_param_group:
amazon.aws.rds_instance_param_group:
name: "{{ rds_param_group.name }}"
state: absent
register: result
Expand Down
Loading