Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rds_param_group to rds_instance_param_group #2058

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Rename rds_param_group to rds_instance_param_group #2058

merged 3 commits into from
Apr 16, 2024

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Rename rds_param_group to rds_instance_param_group

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis alinabuzachis force-pushed the rename_rds_param_group branch from 8b9a25b to 5187a04 Compare April 16, 2024 11:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

tremble
tremble reviewed Apr 16, 2024
View reviewed changes
meta/runtime.yml Outdated Show resolved Hide resolved
tremble
tremble reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(+1 to the rename though)

@alinabuzachis
Update removal version
10c2a55 
Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b3c14ce4285f44688ed499b71f443bc7

✔️ ansible-galaxy-importer SUCCESS in 5m 27s
✔️ build-ansible-collection SUCCESS in 15m 01s
✔️ ansible-test-splitter SUCCESS in 5m 56s
✔️ integration-amazon.aws-1 SUCCESS in 7m 25s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 16, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8adb68f9d9744a1eb6fc4d9db779d8c0

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 15m 00s
✔️ ansible-test-splitter SUCCESS in 6m 30s
✔️ integration-amazon.aws-1 SUCCESS in 7m 06s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 428093e into ansible-collections:main Apr 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alinabuzachis @tremble