[stable-7] Fix missing FQCNs in integration test (#1902) #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
changed the title
SUMMARY
This PR fixes the integration tests to use FQCN throughout. Every change has been generated by running ansible-lint --fix with the write_list limited to fqcn. The one exception is the manual removal of the tests/integration/targets/aws_region_info/main.yml which ansible-lint was failing on. This seems to be unused? It attempts to include tasks/tests.yml which does not exist.
The ansible-lint config used to generate this changeset:
---
exclude_paths:
- plugins/
write_list:
- fqcn
I had to exclude the plugins/ directory because ansible-lint was crashing, I suspect because of docstrings. It did not provide enough information in debug or traceback to identify which file was causing the problem.
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
tremble
force-pushed
the
backports/stable-7/1902
branch
from
1003742 to
8f3eb0b
Compare
gravesm
approved these changes
Dec 6, 2023
alinabuzachis
approved these changes
Dec 7, 2023
|
recheck |
softwarefactory-project-zuul
bot
merged commit b4ab16e
into
ansible-collections:stable-7
39 of 40 checks passed
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the integration tests to use FQCN throughout. Every change has been generated by running ansible-lint --fix with the write_list limited to fqcn. The one exception is the manual removal of the tests/integration/targets/aws_region_info/main.yml which ansible-lint was failing on. This seems to be unused? It attempts to include tasks/tests.yml which does not exist.
The ansible-lint config used to generate this changeset:
I had to exclude the plugins/ directory because ansible-lint was crashing, I suspect because of docstrings. It did not provide enough information in debug or traceback to identify which file was causing the problem.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION