Fix missing FQCNs in integration test (#1902) (#1906)

[stable-7] Fix missing FQCNs in integration test (#1902) SUMMARY This PR fixes the integration tests to use FQCN throughout. Every change has been generated by running ansible-lint --fix with the write_list limited to fqcn. The one exception is the manual removal of the tests/integration/targets/aws_region_info/main.yml which ansible-lint was failing on. This seems to be unused? It attempts to include tasks/tests.yml which does not exist. The ansible-lint config used to generate this changeset: --- exclude_paths: - plugins/ write_list: - fqcn I had to exclude the plugins/ directory because ansible-lint was crashing, I suspect because of docstrings. It did not provide enough information in debug or traceback to identify which file was causing the problem. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Alina Buzachis
ansible-collections · Dec 8, 2023 · b4ab16e · b4ab16e
1 parent 3801882
commit b4ab16e
Show file tree

Hide file tree

Showing 480 changed files with 38,583 additions and 38,844 deletions.
diff --git a/.github/BOTMETA.yml b/.github/BOTMETA.yml
@@ -1,3 +1,4 @@
+---
 automerge: false
 files:
   maintainers: $team_aws

diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -3,159 +3,158 @@ name: Bug report
 description: Create a report to help us improve
 
 body:
-- type: markdown
-  attributes:
-    value: |
-      ⚠
-      Verify first that your issue is not [already reported on GitHub][issue search].
-      Where possible also test if the latest release and main branch are affected too.
-      *Complete **all** sections as described, this form is processed automatically.*
-
-      [issue search]: https://github.com/ansible-collections/amazon.aws/search?q=is%3Aissue&type=issues
-
-- type: textarea
-  attributes:
-    label: Summary
-    description: |
-      Explain the problem briefly below.
-    placeholder: >-
-      When I try to do X with the collection from the main branch on GitHub, Y
-      breaks in a way Z under the env E. Here are all the details I know
-      about this problem...
-  validations:
-    required: true
-
-- type: dropdown
-  attributes:
-    label: Issue Type
-    # FIXME: Once GitHub allows defining the default choice, update this
-    options:
-    - Bug Report
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
+  - type: markdown
+    attributes:
+      value: |
+        ⚠
+        Verify first that your issue is not [already reported on GitHub][issue search].
+        Where possible also test if the latest release and main branch are affected too.
+        *Complete **all** sections as described, this form is processed automatically.*
+
+        [issue search]: https://github.com/ansible-collections/amazon.aws/search?q=is%3Aissue&type=issues
+
+  - type: textarea
+    attributes:
+      label: Summary
+      description: |
+        Explain the problem briefly below.
+      placeholder: >-
+        When I try to do X with the collection from the main branch on GitHub, Y
+        breaks in a way Z under the env E. Here are all the details I know
+        about this problem...
+    validations:
+      required: true
+
+  - type: dropdown
+    attributes:
+      label: Issue Type
+      # FIXME: Once GitHub allows defining the default choice, update this
+      options:
+        - Bug Report
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
     # For smaller collections we could use a multi-select and hardcode the list
     # May generate this list via GitHub action and walking files under https://github.com/ansible-collections/community.general/tree/main/plugins
     # Select from list, filter as you type (`mysql` would only show the 3 mysql components)
     # OR freeform - doesn't seem to be supported in adaptivecards
-    label: Component Name
-    description: >-
-      Write the short name of the module or plugin below,
-      *use your best guess if unsure*.
-    placeholder: ec2_instance, ec2_security_group
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
-    label: Ansible Version
-    description: >-
-      Paste verbatim output from `ansible --version` between
-      tripple backticks.
-    value: |
-      ```console (paste below)
-      $ ansible --version
-
-      ```
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
-    label: Collection Versions
-    description: >-
-      Paste verbatim output from `ansible-galaxy collection list` between
-      tripple backticks.
-    value: |
-      ```console (paste below)
-      $ ansible-galaxy collection list
-      ```
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
-    label: AWS SDK versions
-    description: >-
-      The AWS modules depend heavily on the Amazon AWS SDKs which are regularly updated.
-      Paste verbatim output from `pip show boto boto3 botocore` between quotes
-    value: |
-      ```console (paste below)
-      $ pip show boto boto3 botocore
-      ```
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
-    label: Configuration
-    description: >-
-      If this issue has an example piece of YAML that can help to reproduce this problem, please provide it.
-      This can be a piece of YAML from, e.g., an automation, script, scene or configuration.
-
-      Paste verbatim output from `ansible-config dump --only-changed` between quotes
-    value: |
-      ```console (paste below)
-      $ ansible-config dump --only-changed
-
-      ```
-
-- type: textarea
-  attributes:
-    label: OS / Environment
-    description: >-
-      Provide all relevant information below, e.g. target OS versions,
-      network device firmware, etc.
-    placeholder: RHEL 8, CentOS Stream etc.
-  validations:
-    required: false
-
-- type: textarea
-  attributes:
-    label: Steps to Reproduce
-    description: |
-      Describe exactly how to reproduce the problem, using a minimal test-case. It would *really* help us understand your problem if you could also paste any playbooks, configs and commands you used.
-
-      **HINT:** You can paste https://gist.github.com links for larger files.
-    value: |
-      <!--- Paste example playbooks or commands between quotes below -->
-      ```yaml (paste below)
-
-      ```
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
-    label: Expected Results
-    description: >-
-      Describe what you expected to happen when running the steps above.
-    placeholder: >-
-      I expected X to happen because I assumed Y.
-      that it did not.
-  validations:
-    required: true
-
-- type: textarea
-  attributes:
-    label: Actual Results
-    description: |
-      Describe what actually happened. If possible run with extra verbosity (`-vvvv`).
-
-      Paste verbatim command output between quotes.
-    value: |
-      ```console (paste below)
-
-      ```
-
-- type: checkboxes
-  attributes:
-    label: Code of Conduct
-    description: |
-      Read the [Ansible Code of Conduct](https://docs.ansible.com/ansible/latest/community/code_of_conduct.html?utm_medium=github&utm_source=issue_form--ansible-collections) first.
-    options:
-    - label: I agree to follow the Ansible Code of Conduct
+      label: Component Name
+      description: >-
+        Write the short name of the module or plugin below,
+        *use your best guess if unsure*.
+      placeholder: ec2_instance, ec2_security_group
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Ansible Version
+      description: >-
+        Paste verbatim output from `ansible --version` between
+        tripple backticks.
+      value: |
+        ```console (paste below)
+        $ ansible --version
+
+        ```
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Collection Versions
+      description: >-
+        Paste verbatim output from `ansible-galaxy collection list` between
+        tripple backticks.
+      value: |
+        ```console (paste below)
+        $ ansible-galaxy collection list
+        ```
+    validations:
       required: true
-...
+
+  - type: textarea
+    attributes:
+      label: AWS SDK versions
+      description: >-
+        The AWS modules depend heavily on the Amazon AWS SDKs which are regularly updated.
+        Paste verbatim output from `pip show boto boto3 botocore` between quotes
+      value: |
+        ```console (paste below)
+        $ pip show boto boto3 botocore
+        ```
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Configuration
+      description: >-
+        If this issue has an example piece of YAML that can help to reproduce this problem, please provide it.
+        This can be a piece of YAML from, e.g., an automation, script, scene or configuration.
+
+        Paste verbatim output from `ansible-config dump --only-changed` between quotes
+      value: |
+        ```console (paste below)
+        $ ansible-config dump --only-changed
+
+        ```
+
+  - type: textarea
+    attributes:
+      label: OS / Environment
+      description: >-
+        Provide all relevant information below, e.g. target OS versions,
+        network device firmware, etc.
+      placeholder: RHEL 8, CentOS Stream etc.
+    validations:
+      required: false
+
+  - type: textarea
+    attributes:
+      label: Steps to Reproduce
+      description: |
+        Describe exactly how to reproduce the problem, using a minimal test-case. It would *really* help us understand your problem if you could also paste any playbooks, configs and commands you used.
+
+        **HINT:** You can paste https://gist.github.com links for larger files.
+      value: |
+        <!--- Paste example playbooks or commands between quotes below -->
+        ```yaml (paste below)
+
+        ```
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Expected Results
+      description: >-
+        Describe what you expected to happen when running the steps above.
+      placeholder: >-
+        I expected X to happen because I assumed Y.
+        that it did not.
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: Actual Results
+      description: |
+        Describe what actually happened. If possible run with extra verbosity (`-vvvv`).
+
+        Paste verbatim command output between quotes.
+      value: |
+        ```console (paste below)
+
+        ```
+
+  - type: checkboxes
+    attributes:
+      label: Code of Conduct
+      description: |
+        Read the [Ansible Code of Conduct](https://docs.ansible.com/ansible/latest/community/code_of_conduct.html?utm_medium=github&utm_source=issue_form--ansible-collections) first.
+      options:
+        - label: I agree to follow the Ansible Code of Conduct
+          required: true