is_boto3_error_code - support sets and tuples #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
is_error/tuple
branch
from
90d2778 to
a5289be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
alinabuzachis
approved these changes
Nov 22, 2023
tremble
force-pushed
the
is_error/tuple
branch
from
a5289be to
a64be09
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
regate |
softwarefactory-project-zuul
bot
merged commit 9210f0e
into
ansible-collections:main
39 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
is_boto3_error_code currently supports checking for a list of codes, but if passed a set/tuple of error codes it always returns
NeverEverRaisedException.See also #1813
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION