s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support tags #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
approved these changes
Oct 19, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 03s |
softwarefactory-project-zuul
bot
merged commit 985d8b1
into
ansible-collections:main
63 of 92 checks passed
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1814 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…ags (#1813) s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support tags SUMMARY is_boto3_error_code only supports being passed a string or list. In the refactor of s3_object it was passed a tuple, so the errors weren't being cleanly caught. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION fixes: #1607 Reviewed-by: Alina Buzachis (cherry picked from commit 985d8b1)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
…ags (#1813) (#1814) [PR #1813/985d8b1c backport][stable-6] s3_object - fix NoSuchTagSet error when S3 endpoint doesn't support tags This is a backport of PR #1813 as merged into main (985d8b1). SUMMARY is_boto3_error_code only supports being passed a string or list. In the refactor of s3_object it was passed a tuple, so the errors weren't being cleanly caught. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION fixes: #1607 Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
is_boto3_error_code - support sets and tuples SUMMARY is_boto3_error_code currently supports checking for a list of codes, but if passed a set/tuple of error codes it always returns NeverEverRaisedException. See also #1813 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
is_boto3_error_code only supports being passed a string or list. In the refactor of s3_object it was passed a tuple, so the errors weren't being cleanly caught.
ISSUE TYPE
COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
fixes: #1607