[DNM] [PR #1555/b9d5b48b backport][stable-6] s3_object - deprecate leading slash in object keys #1557
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
#1555) s3_object - deprecate leading slash in object keys SUMMARY Deprecate support for removing leading / from object names AWS APIs don't expect it to be there, pruning it may cause pain in future ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Deprecation was split from #1549 Reviewed-by: Alina Buzachis (cherry picked from commit b9d5b48)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
changed the title
tremble
approved these changes
May 17, 2023
|
This PR should NOT be merged prior to 6.0.1 being released |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 40s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 36s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-6/b9d5b48b17c8be9ab171086122eb7e60b75cd901/pr-1555
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ons#1557) Add origin shield in cloudfront_distribution module SUMMARY Add Origin Shield option to cloudfront_distribution module. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudfront_distribution.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ons#1557) Add origin shield in cloudfront_distribution module SUMMARY Add Origin Shield option to cloudfront_distribution module. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudfront_distribution.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ons#1557) Add origin shield in cloudfront_distribution module SUMMARY Add Origin Shield option to cloudfront_distribution module. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudfront_distribution.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1555 as merged into main (b9d5b48).
SUMMARY
Deprecate support for removing leading
/from object namesAWS APIs don't expect it to be there, pruning it may cause pain in future
ISSUE TYPE
COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Deprecation was split from #1549