Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3_object - deprecate leading slash in object keys #1555

Merged
merged 1 commit into from
May 17, 2023
Merged

s3_object - deprecate leading slash in object keys #1555

merged 1 commit into from
May 17, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 17, 2023 •
edited
Loading

SUMMARY

Deprecate support for removing leading / from object names

AWS APIs don't expect it to be there, pruning it may cause pain in future

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_object

ADDITIONAL INFORMATION

Deprecation was split from #1549

@tremble tremble force-pushed the deprecate/s3_object/leading_slash branch from 9482f7e to bf43d6c Compare May 17, 2023 12:20
@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble marked this pull request as ready for review May 17, 2023 12:20
@tremble tremble requested a review from alinabuzachis May 17, 2023 12:20
@tremble tremble added the backport-6 PR should be backported to the stable-6 branch label May 17, 2023
@tremble
Copy link
Contributor Author

tremble commented May 17, 2023

Should be backported to stable-6 after we've cut 6.0.1

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b3016f9dc13d469cae00c84a2d170ffb

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 13m 01s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 9m 32s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 17, 2023
@tremble tremble changed the title Deprecate/s3 object/leading slash s3_object - deprecate leading slash in object keys May 17, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/985d2e2bbd5d4cfdba9ef7489d9725b5

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 12m 46s
✔️ ansible-test-splitter SUCCESS in 4m 45s
✔️ integration-amazon.aws-1 SUCCESS in 12m 48s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b9d5b48 into ansible-collections:main May 17, 2023
@patchback
Copy link

patchback bot commented May 17, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b9d5b48b17c8be9ab171086122eb7e60b75cd901/pr-1555

Backported as #1557

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2023
@tremble @patchback
s3_object - Deprecate support for removing leading / from object names (
fa6bd3c 
#1555)

s3_object - deprecate leading slash in object keys

SUMMARY
Deprecate support for removing leading / from object names
AWS APIs don't expect it to be there, pruning it may cause pain in future
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Deprecation was split from #1549

Reviewed-by: Alina Buzachis
(cherry picked from commit b9d5b48)
@patchback patchback bot mentioned this pull request May 17, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 22, 2023
@patchback
s3_object - Deprecate support for removing leading / from object names (
1b5ab75 
#1555) (#1557)

[DNM] [PR #1555/b9d5b48b backport][stable-6] s3_object - deprecate leading slash in object keys

This is a backport of PR #1555 as merged into main (b9d5b48).
SUMMARY
Deprecate support for removing leading / from object names
AWS APIs don't expect it to be there, pruning it may cause pain in future
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Deprecation was split from #1549

Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@markuman
wafv2_rule_group_info: remove state parameter (ansible-collections#1555)
d838bc4 
wafv2_rule_group_info: remove state parameter

SUMMARY
closes ansible-collections#1547
ISSUE TYPE

COMPONENT NAME
wafv2_rule_group_info
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@markuman @abikouo
wafv2_rule_group_info: remove state parameter (ansible-collections#1555)
1f1a946 
wafv2_rule_group_info: remove state parameter

SUMMARY
closes ansible-collections#1547
ISSUE TYPE

COMPONENT NAME
wafv2_rule_group_info
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the deprecate/s3_object/leading_slash branch September 27, 2023 07:00
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@markuman
wafv2_rule_group_info: remove state parameter (ansible-collections#1555)
3de5faf 
wafv2_rule_group_info: remove state parameter

SUMMARY
closes ansible-collections#1547
ISSUE TYPE

COMPONENT NAME
wafv2_rule_group_info
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @alinabuzachis