Move exceptions into their own python module #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
refacter/exceptions
branch
from
ade3b08 to
4c8cb9a
Compare
ansibullbot
added
community_review
feature
tremble
force-pushed
the
refacter/exceptions
branch
from
4c8cb9a to
8b94886
Compare
alinabuzachis
approved these changes
Nov 4, 2022
|
regate |
|
regate |
|
regate |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
…e reuse (#1227) Move botocore version validation into module_utils.botocore for future reuse Depends-On: #1246 SUMMARY In preparation for #1225 move the SDK version validation pieces over into module_utils.botocore ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/core.py plugins/module_utils/exceptions.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
Refacter get_aws_connection_info / get_aws_region Depends-On: #1246 SUMMARY Splits up the logic for get_aws_region and get_aws_connection_info so that it can be reused by non-module plugins. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move base/core exceptions into their own python module
ISSUE TYPE
COMPONENT NAME
module_utils
ADDITIONAL INFORMATION