Refacter get_aws_connection_info / get_aws_region #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/boto3_connections
branch
from
a228804 to
28eae36
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
community_review
feature
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
tremble
changed the title
tremble
force-pushed
the
refacter/boto3_connections
branch
from
28eae36 to
bc2ee31
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto3_connections
branch
2 times, most recently
from
79555eb to
027e5be
Compare
tremble
force-pushed
the
refacter/boto3_connections
branch
from
027e5be to
e456b4e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto3_connections
branch
from
e456b4e to
2108a68
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto3_connections
branch
from
2108a68 to
cfdd170
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto3_connections
branch
from
cfdd170 to
28f7772
Compare
alinabuzachis
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1246
SUMMARY
Splits up the logic for get_aws_region and get_aws_connection_info so that it can be reused by non-module plugins.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION