Backport Linting cleanup from 1181 #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial backport of ansible-collections#1181 ##### SUMMARY Minor linting cleanup missing whitespace ##### ISSUE TYPE Feature Pull Request ##### COMPONENT NAME plugins/inventory/aws_ec2.py plugins/modules/s3_object_info.py ##### ADDITIONAL INFORMATION Original Reviews: Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
Merged
ansibullbot
added
community_review
feature
|
@alinabuzachis Might be just as easy to merge this and then rebase #1216 |
alinabuzachis
approved these changes
Oct 28, 2022
softwarefactory-project-zuul
bot
merged commit ff97b24
into
ansible-collections:stable-5
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 28, 2022
Backport Linting cleanup from 1181 Partial backport of ansible-collections#1181 SUMMARY Minor linting cleanup missing whitespace ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/modules/s3_object_info.py ADDITIONAL INFORMATION Original Reviews: Reviewed-by: Alina Buzachis Reviewed-by: Gonéri Le Bouder Reviewed-by: Alina Buzachis <None>
markuman
pushed a commit
to markuman/amazon.aws
that referenced
this pull request
Nov 14, 2022
cloudtrail - add support for purge_tags SUMMARY Move to tagging docs fragment Update tagging code so that "tags" must be explicitly passed to remove tags add purge_tags parameter add resource_tags as an alias for tags Update tagging code so that tags are set as part of the create call rather than tagging after creation ISSUE TYPE Feature Pull Request COMPONENT NAME cloudtrail ADDITIONAL INFORMATION Note: tests are currently not run in CI. Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@53e3bb2
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
cloudtrail - add support for purge_tags SUMMARY Move to tagging docs fragment Update tagging code so that "tags" must be explicitly passed to remove tags add purge_tags parameter add resource_tags as an alias for tags Update tagging code so that tags are set as part of the create call rather than tagging after creation ISSUE TYPE Feature Pull Request COMPONENT NAME cloudtrail ADDITIONAL INFORMATION Note: tests are currently not run in CI. Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
cloudtrail - add support for purge_tags SUMMARY Move to tagging docs fragment Update tagging code so that "tags" must be explicitly passed to remove tags add purge_tags parameter add resource_tags as an alias for tags Update tagging code so that tags are set as part of the create call rather than tagging after creation ISSUE TYPE Feature Pull Request COMPONENT NAME cloudtrail ADDITIONAL INFORMATION Note: tests are currently not run in CI. Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
cloudtrail - add support for purge_tags SUMMARY Move to tagging docs fragment Update tagging code so that "tags" must be explicitly passed to remove tags add purge_tags parameter add resource_tags as an alias for tags Update tagging code so that tags are set as part of the create call rather than tagging after creation ISSUE TYPE Feature Pull Request COMPONENT NAME cloudtrail ADDITIONAL INFORMATION Note: tests are currently not run in CI. Reviewed-by: Joseph Torcasso <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial backport of #1181
SUMMARY
Minor linting cleanup
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/modules/s3_object_info.py
ADDITIONAL INFORMATION
Original Reviews:
Reviewed-by: Alina Buzachis
Reviewed-by: Gonéri Le Bouder