Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep 5.1.0 release #1216

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Prep 5.1.0 release

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

several

@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage labels Oct 27, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 5m 57s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 29s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 49s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 09s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 31s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 36s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 24s
✔️ cloud-tox-py3 SUCCESS in 3m 07s

changelogs/changelog.yaml Outdated Show resolved Hide resolved
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble
Copy link
Contributor

tremble commented Oct 28, 2022

#1219 is ready to merge (will need to remove the sanity ignores files) once we've finished the 5.1.0 release

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 5m 07s
ansible-test-sanity-aws-ansible-python38 FAILURE in 11m 15s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 53s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 39s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 8m 36s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 07s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 38s
✔️ cloud-tox-py3 SUCCESS in 3m 09s

@alinabuzachis
Copy link
Collaborator Author

@tremble these ones seems unnecessary.

ERROR: Found 2 pep8 issue(s) which need to be resolved:
--
1027 | 2022-10-28 09:34:54.750472 \| controller \| ERROR: tests/sanity/ignore-2.14.txt:1:1: A100: Ignoring 'E275' on 'plugins/inventory/aws_ec2.py' is unnecessary
1028 | 2022-10-28 09:34:54.750477 \| controller \| ERROR: tests/sanity/ignore-2.14.txt:3:1: A100: Ignoring 'E275' on 'plugins/modules/s3_object_info.py' is unnecessary

alinabuzachis and others added 2 commits October 28, 2022 14:39
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 4m 57s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 04s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 29s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 31s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 12s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 05s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 53s
✔️ cloud-tox-py3 SUCCESS in 3m 12s

@alinabuzachis
Copy link
Collaborator Author

@tremble can we merge it now?

@tremble
Copy link
Contributor

tremble commented Oct 28, 2022

Yup, I was leaving it to you.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Oct 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 4m 57s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 23s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 43s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 34s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 18s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 27s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 23s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 33s
✔️ cloud-tox-py3 SUCCESS in 3m 06s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 54ce7db into ansible-collections:stable-5 Oct 28, 2022
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 28, 2022
Prep 5.1.0 release

SUMMARY

Prep 5.1.0 release

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

several

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
wafv2_web_acl - fix return values

SUMMARY

split integration tests from full wafv2 tests
relax botocore requirement to bare minimum required
return web acl info on update
consistently return web acl info as described in documentation (create would nest it under "web_acl")
fix "changed" value when description not specified

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
wafv2_web_acl - fix return values

SUMMARY

split integration tests from full wafv2 tests
relax botocore requirement to bare minimum required
return web acl info on update
consistently return web acl info as described in documentation (create would nest it under "web_acl")
fix "changed" value when description not specified

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
wafv2_web_acl - fix return values

SUMMARY

split integration tests from full wafv2 tests
relax botocore requirement to bare minimum required
return web acl info on update
consistently return web acl info as described in documentation (create would nest it under "web_acl")
fix "changed" value when description not specified

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_maintainer needs_triage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants