Promote elb_application_lb* module and test #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@eb75681
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@13b104b
* Rename core collection Rename references to ansible.amazon to amazon.aws. * Rename community.amazon to community.aws Fix pep8 line lengths for rewritten amazon.aws imports * Missed a path in shippable.sh * Dependency repos moved This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@235c5db
Coverage versions 5 and later are not supported by ansible-test. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c2bb050
* Remove ANSIBLE_METADATA entirely, see ansible/ansible/pull/69454. Remove `license` field from galaxy.yml, in favor of `license_file`. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@05672a6
* Update module deprecations Switch version to `removed_at_date` * Don't install amazon.aws from galaxy We've been using galaxy to install amazon.aws in shippable, but that doesn't really work if we aren't publising faster. Get that collection from git so it is most up to date. * We need to declare python test deps now * missed a python dep This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7cd211e
Updated module examples with FQCN Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@98173ae
Co-authored-by: Ezekiel Hendrickson <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@10853d9
* Update docs Remove .git from repo url so links in readme will generate correctly Add required ansible version Run latest version of add_docs.py Add version_added string to modules * galaxy.yml was missing authors This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@96ee268
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
* Update comments to reference AnsibleAWSModule rather than AnsibleModule * Bulk re-order imports and split onto one from import per-line. * Add AnsibleAWSModule imports * Migrate boto 2 based modules to AnsibleAWSModule * Move boto3-only modules over to AnsibleAWSModule * Remove extra ec2_argument_spec calls - not needed now we're using AnsibleAWSModule * Remove most HAS_BOTO3 code, it's handled by AnsibleAWSModule * Handle missing Boto 2 consistently (HAS_BOTO) * Remove AnsibleModule imports * Changelog fragment This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@818c6d2
…r(e) or e.me… (ansible-collections#26) * Py3 compat error handling: use to_native(e) instead of str(e) or e.message * PR comment changes, use fail_json_aws and is_boto3_error_code This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ffe14f9
…ollections#188) * Migrate from boto3_conn to module.client * Simplify error handling when creating connections * Simplify Region handling * Remove unused imports * Changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6bdf00d
…ions#320) * Sanity test / doc-default-does-not-match-spec fixups * General docs cleanup This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b22f280
…llections#350) state=`absent`: Properly remove the associated listeners before the final removal of the object. See: ansible/ansible#49291 This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@0cf5326
* Split imports and reorder * Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations * Remove unused imports * Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@130cf3c
Remove the `unsupported` aliases for the `elb_application_lb` test. Use HTTP instead of HTTPS to avoid the dependency on `iam:ListServerCertificates` and the other Certificate related operations. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5f3c86c
* Split imports and sort * Move camel_dict_to_snake_dict imports to ansible.module_utils.common.dict_transformations * Cleanup unused imports * Bulk migration to fail_json_aws * Changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6c88315
* Bulk migration to module_defaults * Tests for missing creds/region * Move dms_identifier and dms_sg_identifier into defaults This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@365b6ef
…ns#467) * Move ec2_launch_template to standard role-type test * Run elb_application_lb in our standard environment * Move elb_target_info to the standard role structure * add remote_tmp_dir dependency to ec2_launch_template * move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice * Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us * Ensure ALBs are deleted if "failed" tests created something This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@887d624
…ions#347) * elb_application_lb: test a rule based on http-header This should initially fail and be fixed the day ansible-collections#188 is merged. See: ansible-collections#187 See: ansible-collections/community.aws#117 Co-authored-by: Mark Chappell <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@8c0ea48
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3ddf6d0
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@49c303c
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2276333
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c9bd864
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@708b3d5
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@1e8e79c
Co-authored-by: Jill R <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3904041
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ad8b1b4
GomathiselviS
changed the base branch from
promote_elb_application_lb
to
main
|
@GomathiselviS This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
|
@GomathiselviS: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
needs_info
|
recheck |
jillr
approved these changes
Sep 20, 2022
abikouo
reviewed
Sep 21, 2022
abikouo
approved these changes
Sep 21, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Oops, it has been merged with |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
eks_fargate_profile: incr version added SUMMARY CI is failing for stable-3 branch NotImplementedError: Waiter fargate_profile_active could not be found for client <class 'botocore.client.EKS'>. Possibly because the boto3 version in the main branch is higher as in the stable-3 branch. It's still possible to backport this for the next 3.3.0 release. The integration test must install a higher boto3 version. ISSUE TYPE Docs Pull Request COMPONENT NAME eks_fargate_profile Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
eks_fargate_profile: incr version added SUMMARY CI is failing for stable-3 branch NotImplementedError: Waiter fargate_profile_active could not be found for client <class 'botocore.client.EKS'>. Possibly because the boto3 version in the main branch is higher as in the stable-3 branch. It's still possible to backport this for the next 3.3.0 release. The integration test must install a higher boto3 version. ISSUE TYPE Docs Pull Request COMPONENT NAME eks_fargate_profile Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
eks_fargate_profile: incr version added SUMMARY CI is failing for stable-3 branch NotImplementedError: Waiter fargate_profile_active could not be found for client <class 'botocore.client.EKS'>. Possibly because the boto3 version in the main branch is higher as in the stable-3 branch. It's still possible to backport this for the next 3.3.0 release. The integration test must install a higher boto3 version. ISSUE TYPE Docs Pull Request COMPONENT NAME eks_fargate_profile Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/zuul-config#443
SUMMARY
Migrate elb_application_lb* module