Fix typo for deleting a DHCP Option Set #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix alignment of `state` parameter to be passed as a module parameter instead of a task parameter.
tremble
requested changes
Aug 12, 2020
There was a problem hiding this comment.
Thanks for the Pull Request
The rst files are auto-generated from the module, as such this should be fixed in ec2_vpc_dhcp_option.py rather than here. It would be good if you could update this as @jillr is preparing the 1.1.0 release.
|
Closing in favor of change to root module. |
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 3, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]>
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 10, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]>
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 10, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]>
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 13, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]>
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Jun 21, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]>
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@0b9b2dc
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws -- 337 -- See: ansible-collections/community.aws@059cf9e
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 15, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 15, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 15, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 16, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 16, 2021
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@059cf9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix alignment of
stateparameter to be passed as a module parameter instead of a task parameter.SUMMARY
Simple typo fix
ISSUE TYPE
COMPONENT NAME
ec2_vpc_dhcp_option
ADDITIONAL INFORMATION
None