Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for application-level Merkle trees #55

Closed
Tracked by #62
juped opened this issue Jan 26, 2022 · 2 comments
Closed
Tracked by #62

Support for application-level Merkle trees #55

juped opened this issue Jan 26, 2022 · 2 comments
Assignees
@murisi
Labels
MASP

Comments

@juped
Copy link
Member

juped commented Jan 26, 2022 •
edited by sync-by-unito bot
Loading

It may be best to specialize this to ZK commitment trees specifically, which is a common specific use case. Also requires gas metering.

┆Issue is synchronized with this Asana task by Unito
@juped juped added the MASP label Jan 26, 2022
This was referenced Jul 7, 2022
Closed
Closed
@sync-by-unito sync-by-unito bot closed this as completed Feb 3, 2022
@juped juped reopened this Feb 3, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@cwgoes
Copy link
Contributor

cwgoes commented Jan 12, 2023

@murisi did we do this as part of the MASP VP already?

@murisi
Copy link
Contributor

murisi commented Jan 22, 2023

@cwgoes @juped I believe this is done: we simply use the Merkle tree primitives from the anoma/masp crate. Specifically we have the CommitmentTree and FrozenCommitmentTree primitives, each providing different performance characteristics. However I don't believe that gas metering in the context of these Merkle trees has yet been handled...

@murisi murisi closed this as completed Jan 22, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@jurevans
Merge pull request anoma#55 from heliaxdev/feat/36-redux-and-other-ui…
25069e3 
…-improvements

feat/36 - Clean up Account Creation
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@memasdeligeorgakis
anoma#50 staking view and table component (anoma#54)
1b8160a 
* Manually copied over the changes from feat/47_staking_gov_pgf, as there
  had been a big refactor and this could not be merged automatically
* Had to add containers as we have `Appcomponents__ContentContainer`
  which is not display: flex and in the account views things would break
  in the current form, if this was to be changed to flex. Should be
  refactored though
* Deleted left over files from merge
* creating Table component
* navigation and main components in Staking view
* anoma#55 Staking and Governance State (anoma#56)
* Initial files for staking and governance state
* created types in Redux
* moving fake data and table configurations away from a file next to the component
* validator data through action and Redux
* changed the way how to pass callbacks to table rows
* removed console logs and added comments to indicate upcoming functionality
* put back the placeholder view elements to new routes
* Fixes based on PR feedback
* Changed naming on PR#54 feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murisi murisi

Labels
MASP
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juped @murisi @cwgoes