Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic wallet writes #50

Closed
Tracked by #2533
tzemanovic opened this issue Jan 17, 2022 · 2 comments · May be fixed by #2831
Closed
Tracked by #2533

atomic wallet writes #50

tzemanovic opened this issue Jan 17, 2022 · 2 comments · May be fixed by #2831
Labels
ledger pre-mainnet Must happen before mainnet. wallet

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Jan 17, 2022

Change the API of the wallet so that instead of save method, the modification methods are atomic. We can load the wallet file with a lock on modifications (the lock's scope should be as small as possible), make the modification, save to file and release the lock. This is to allow avoid data-races from multiple processes

┆Issue is synchronized with this Asana task by Unito

@sync-by-unito sync-by-unito bot closed this as completed Feb 3, 2022
@juped juped reopened this Feb 3, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@cwgoes
Copy link
Contributor

cwgoes commented Jan 12, 2023

@karbyshev can you take this on as part of the wallet work?

@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 5, 2024
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* Manually copied over the changes from feat/47_staking_gov_pgf, as there
  had been a big refactor and this could not be merged automatically
* Had to add containers as we have `Appcomponents__ContentContainer`
  which is not display: flex and in the account views things would break
  in the current form, if this was to be changed to flex. Should be
  refactored though
* Deleted left over files from merge
* creating Table component
* navigation and main components in Staking view
* anoma#55 Staking and Governance State (anoma#56)
* Initial files for staking and governance state
* created types in Redux
* moving fake data and table configurations away from a file next to the component
* validator data through action and Redux
* changed the way how to pass callbacks to table rows
* removed console logs and added comments to indicate upcoming functionality
* put back the placeholder view elements to new routes
* Fixes based on PR feedback
* Changed naming on PR#54 feedback
@karbyshev karbyshev mentioned this issue Mar 8, 2024
2 tasks
@brentstone brentstone added this to the To evaluate milestone Apr 15, 2024
@cwgoes
Copy link
Contributor

cwgoes commented Aug 29, 2024

Until a real user has a real problem, we are not doing this.

@cwgoes cwgoes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledger pre-mainnet Must happen before mainnet. wallet
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

5 participants