WYSIWYG Editor #9048

Akshay0701 · 2021-06-02T12:45:49Z

Purpose / Description

Follow-on from #7962 with commits cleaned and most review feedback handled.

Performed as trgk on Discord is interested and it'd be great to get this across the finish line.

Required:

A few TODOs related to the WebView renderer crashing. See: onRenderProcessGone

Fixes

Fixes #1377

Features

Akshay0701 · 2021-06-02T12:46:59Z

should we consider this https://github.com/mrudultora/Colorpicker color picker ?

mikehardy · 2021-06-02T19:20:24Z

I'm okay with @mrudultora's color picker yes

Akshay0701 · 2021-06-10T04:31:50Z

@david-allison-1 you mentioned in #9048 (comment) that the iframe is not working, I did search whether its summer note problem or browser and found the cause tneotia/html-editor-enhanced#12

the solution is to append `https: in src then it's working fine

Akshay0701 · 2021-06-10T04:37:52Z

one question: do we really need to give the option to embed links or videos in notes? because upstream anki doesn't have that functionality.

david-allison · 2021-06-10T15:59:38Z

one question: do we really need to give the option to embed links or videos in notes? because upstream anki doesn't have that functionality.

If Anki didn't have it, then there's no need to handle it

AnkiDroid/src/main/java/com/ichi2/anki/Whiteboard.java

AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/activity/VisualEditorActivity.java

AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/visualeditor/FontSelectionDialog.java

AnkiDroid/src/main/res/drawable/ic_visibility_black_24dp.xml

AnkiDroid/src/main/res/drawable/ic_visibility_white_24dp.xml

AnkiDroid/src/main/res/values/16-multimedia-editor.xml

AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/activity/VisualEditorActivity.java

AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/visualeditor/WebViewUndoRedo.java

AnkiDroid/src/main/java/com/ichi2/anki/RegisterMediaForWebView.java

prateek-singh-3212 · 2021-06-11T06:10:39Z

Hi @Akshay0701 ,
I Just wanted to ask that have you updated the summernote version? because in the version which we are using their are several bugs in it (I have Not followed this PR for long time so I don't know if you have done so..).

@david-allison-1 I Just wanted to know that how to do I contribute in this PR ? I their is the way by which 2 people can contribute in 1 PR.

Akshay0701 · 2021-06-11T11:49:11Z

I Just wanted to know that how to do I contribute to this PR? There is a way by which 2 people can contribute to 1 PR.

yes sure,
pull this pr on your local machine,
then clone pr and you can change and add commits to it,
after you did publish your branch and share its link here, we will look at that branch and I will cherry-pick your commits
btw what will you like to contribute?

This is because summernote cannot currently cut if an image is selected, so we implement this ourselves. WebView is also buggy, disallowing "cut" on the CAB if only an image is selected, so we fix this via creating a custom MenuItem.

Equation icon my own work. Derivative of Roboto Font and Google Material Design icons Licensing under Apache 2.

To stop TransactionTooLargeException

Akshay0701 · 2022-01-14T19:04:11Z

updates

cleaned the code(more to be done),
comment redo/undo buttons for now(will solve this bug)
audio button error(i looked into it, new changes have been done, wherein audio recording activity needs fields, whereas in visual editor activity we don't have all fields, I still don't understand the error properly, trying...)
commits are full of mess(pardon me for this, don't review the code commit vise, i request reviewers to review the whole activity of visual editor, and let me know if there are more bugs or any changes you want)

1 Extracted toolbar code to VisualEditorToolbar 2 Dropped OrderedList and UnorderedList feature from editor(buggy and AnkiDesktop doesn't have this feature) 3 Dropped RegisterMediaForWebView and used MediaRegistration class 4 audio fix

github-actions · 2022-06-25T16:43:40Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

Akshay0701 force-pushed the visual_editor branch 6 times, most recently from bbc9340 to 89fa147 Compare June 5, 2021 18:53

Akshay0701 marked this pull request as ready for review June 6, 2021 14:56

Akshay0701 marked this pull request as draft June 6, 2021 16:18

Akshay0701 force-pushed the visual_editor branch 2 times, most recently from 7b35cb8 to 88c0d98 Compare June 9, 2021 06:23