Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web page not found when inserting video url #12

Closed
aniketsongara opened this issue Mar 22, 2021 · 7 comments
Closed

Web page not found when inserting video url #12

aniketsongara opened this issue Mar 22, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@aniketsongara
Copy link

Web page not found is showing in editor whenever I am trying to insert the video url from insert Video Url.
but when was checking Code view I got this :

<p><iframe frameborder="0" src="//www.youtube.com/embed/W1pNjxmNHNQ" width="640" height="360" class="note-video-clip"></iframe><br></p>

In above I append https: in src then it's working fine.

<p><iframe frameborder="0" src="https://www.youtube.com/embed/W1pNjxmNHNQ" width="640" height="360" class="note-video-clip"></iframe><br></p>

It's issue is coming only in mobile platform. on web it's working. please add this changes in iframe of lib/summernote/summernote-lite.min.js

@aniketsongara aniketsongara added the bug Something isn't working label Mar 22, 2021
@tneotia
Copy link
Owner

tneotia commented Mar 22, 2021

What is the URL you type into the "insert video" field? Does it start with "www" or directly "youtube.com"?

@aniketsongara
Copy link
Author

Inserting youtube video url start with simple https:
url is https://www.youtube.com/watch?v=W1pNjxmNHNQ

@tneotia
Copy link
Owner

tneotia commented Mar 22, 2021

Thanks - this is apparently a known issue in Summernote: summernote/summernote#3252

Let me see if I can modify the source to fix this.

@aniketsongara
Copy link
Author

Welcome, You can do it you just need to go in lib/assets/summernote-lite.min.js as I mentioned above and search the ifram code then append https: in that. Thanks

Thanks - this is apparently a known issue in Summernote: summernote/summernote#3252

Let me see if I can modify the source to fix this.

@tneotia
Copy link
Owner

tneotia commented Mar 22, 2021

Done, thanks for reporting!

I am releasing 1.7.0+1 with the various fixes for the recent issues.

@aniketsongara
Copy link
Author

I am waiting for it.

Done, thanks for reporting!

I am releasing 1.7.0+1 with the various fixes for the recent issues.

@tneotia
Copy link
Owner

tneotia commented Mar 22, 2021

It is uploaded and should be available now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants