Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter windows unit test to remove pagefile or configure it correctly #15372

Closed
3 of 4 tasks
mikehardy opened this issue Jan 31, 2024 · 3 comments · Fixed by #15388
Closed
3 of 4 tasks

Alter windows unit test to remove pagefile or configure it correctly #15372

mikehardy opened this issue Jan 31, 2024 · 3 comments · Fixed by #15388
Labels
CI Dev Development, testing & CI
Milestone

Comments

@mikehardy
Copy link
Member

Checked for duplicates?

  • This issue is not a duplicate

What are the steps to reproduce this bug?

Examine a windows unit test run and see this:

Error: Exception calling "SetPageFileSize" with "3" argument(s): "The operation completed successfully"
At D:\a\_actions\al-cheb\configure-pagefile-action\v1.3\scripts\SetPageFileSize.ps1:193 char:1
+ [Util.PageFile]::SetPageFileSize($minimumSize, $maximumSize, $diskRoo ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : Win32Exception

Expected behaviour

Successful completion not an error

Actual behaviour

Error message above

Debug info

Current main as of this typing

(Optional) Anything else you want to share?

I believe switching the root from D: to C: will fix it as discussed here (and with verification of the fix appearing to work on a repo using it, that linked to that issue, upon examination of their run logs) - al-cheb/configure-pagefile-action#18 (comment)

Research

  • I am reporting a bug specific to AnkiDroid (Android app)
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@mikehardy mikehardy added Dev Development, testing & CI CI labels Jan 31, 2024
@mikehardy
Copy link
Member Author

Also, hopefully my fix of that action from node 16 to node 20 will quiet some CI warnings al-cheb/configure-pagefile-action#20

@mikehardy
Copy link
Member Author

still waiting on my upstream PR to work through process there before I turn focus back here

@mikehardy
Copy link
Member Author

upstream merged as 1.4. I think I prefer to have a pagefile than not, and have any windows CI issue be a performance issue vs a crash issue, so I'll go for "configure it correctly"

mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Feb 2, 2024
- use new v1.4 tag that updates action to node 20 to quiet warning
- use C: drive since D: has issues (ankidroid#15372)
github-merge-queue bot pushed a commit that referenced this issue Feb 2, 2024
- use new v1.4 tag that updates action to node 20 to quiet warning
- use C: drive since D: has issues (#15372)
@github-actions github-actions bot added this to the 2.17 release milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Dev Development, testing & CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant