Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node 20 in place of 16 #20

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

mikehardy
Copy link
Contributor

@al-cheb thanks for making this action! I've been using it gratefully over in AnkiDroid

Followed the pattern present in the last node change where transitives and node were bumped: 86589fd

Should be easy to review, does not seem controversial?

Fixes #19

@mikehardy
Copy link
Contributor Author

Fixed up and re-pushed, sorry I got the tag wrong first attempt!

@al-cheb
Copy link
Owner

al-cheb commented Feb 2, 2024

Fixed up and re-pushed, sorry I got the tag wrong first attempt!

The build failed:
https://github.com/al-cheb/configure-pagefile-action/actions/runs/7743298527/job/21141273872?pr=20

@mikehardy
Copy link
Contributor Author

mikehardy commented Feb 2, 2024

Yeah it did. That happens when there's really old software trying to run on node 20:

ncc: Version 0.21.1
ncc: Compiling file index.js
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:68:1[9](https://github.com/al-cheb/configure-pagefile-action/actions/runs/7743298527/job/21141273872#step:5:10))
    at Object.createHash (node:crypto:138:[10](https://github.com/al-cheb/configure-pagefile-action/actions/runs/7743298527/job/21141273872#step:5:11))
    at hashOf (evalmachine.<anonymous>:1:14[11](https://github.com/al-cheb/configure-pagefile-action/actions/runs/7743298527/job/21141273872#step:5:12)831)
    at module.exports (evalmachine.<anonymous>:1:14[13](https://github.com/al-cheb/configure-pagefile-action/actions/runs/7743298527/job/21141273872#step:5:14)919)
    at runCmd (evalmachine.<anonymous>:1:46102)
    at 819 (evalmachine.<anonymous>:1:43078)
    at __webpack_require__ (evalmachine.<anonymous>:1:2[16](https://github.com/al-cheb/configure-pagefile-action/actions/runs/7743298527/job/21141273872#step:5:17))
    at startup (evalmachine.<anonymous>:1:353)
    at module.exports.8 (evalmachine.<anonymous>:1:385)
    at evalmachine.<anonymous>:1:395 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

I didn't want to do more than a minimal PR, but I can do an update of the JS deps as well, it will likely fix this. I'll push those in a separate commit so they may be examined (and perhaps discarded, done in a separate PR and this one rebased on it perhaps) on your option

Ran `npm outdated` to examine outdated dependencies, and bumped all of them

- @zeit/ncc is no longer maintained, @vercel/ncc is current dep
- typescript v4+ requires typing for errors in catch

Handled the typescript error typing in what appears to be the idiomatic
way, e.g. https://stackoverflow.com/a/64452744
@mikehardy
Copy link
Contributor Author

mikehardy commented Feb 2, 2024

Final commit I pushed has a commit message with process used, in case that's necessary:

Ran `npm outdated` to examine outdated dependencies, and bumped all of them

- @zeit/ncc is no longer maintained, @vercel/ncc is current dep
- typescript v4+ requires typing for errors in catch

Handled the typescript error typing in what appears to be the idiomatic
way, e.g. https://stackoverflow.com/a/64452744

@mikehardy
Copy link
Contributor Author

@al-cheb it finally passed everything here :-), sorry for the back and forth, was doing this PR mostly as an "opportunistic drive-by" just trying to help since I use the action, but not paying a huge amount of attention to it. I think it's all good now though

@al-cheb al-cheb merged commit a3b6ebd into al-cheb:master Feb 2, 2024
1 check passed
@mikehardy mikehardy deleted the mikehardy-patch-1 branch February 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to node20
2 participants