-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use node 20 in place of 16 #20
Conversation
376c56c
to
e7aac1b
Compare
Fixed up and re-pushed, sorry I got the tag wrong first attempt! |
The build failed: |
Yeah it did. That happens when there's really old software trying to run on node 20:
I didn't want to do more than a minimal PR, but I can do an update of the JS deps as well, it will likely fix this. I'll push those in a separate commit so they may be examined (and perhaps discarded, done in a separate PR and this one rebased on it perhaps) on your option |
Ran `npm outdated` to examine outdated dependencies, and bumped all of them - @zeit/ncc is no longer maintained, @vercel/ncc is current dep - typescript v4+ requires typing for errors in catch Handled the typescript error typing in what appears to be the idiomatic way, e.g. https://stackoverflow.com/a/64452744
Final commit I pushed has a commit message with process used, in case that's necessary:
|
@al-cheb it finally passed everything here :-), sorry for the back and forth, was doing this PR mostly as an "opportunistic drive-by" just trying to help since I use the action, but not paying a huge amount of attention to it. I think it's all good now though |
@al-cheb thanks for making this action! I've been using it gratefully over in AnkiDroid
Followed the pattern present in the last node change where transitives and node were bumped: 86589fd
Should be easy to review, does not seem controversial?
Fixes #19