Added Radioactivity #915
Closed
Added Radioactivity #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
========================================
- Coverage 82.7% 82.7% -0.0%
========================================
Files 291 293 +2
Lines 44038 44392 +354
========================================
+ Hits 36418 36705 +287
- Misses 7620 7687 +67
Continue to review full report at Codecov.
|
angularsen
requested changes
Apr 8, 2021
| "Abbreviations": [ "Bq" ] | ||
| }, | ||
| { | ||
| "Culture": "en-AU", |
There was a problem hiding this comment.
en-US is the default culture, so you can safely remove en-AU here since all the unit abbreviations are identical.
| }, | ||
| "FromUnitToBaseFunc": "x*3.7e10", | ||
| "FromBaseToUnitFunc": "x/3.7e10", | ||
| "Prefixes": [ "micro", "milli" ], |
There was a problem hiding this comment.
For consistency, please start with a big letter in prefixes.
| // Override properties in base class here | ||
| protected override double BecquerelsInOneBecquerel => 1; | ||
|
|
||
| protected override double CuriesInOneBecquerel => 2.702702702e-11; |
There was a problem hiding this comment.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Merged
angularsen
pushed a commit
that referenced
this pull request
Dec 28, 2023
Added Radioactivity (radioactive decay), along with three units: Bq - Becquerel (SI-derived) Ci - Curie (non-SI) Rd - Rutherford (non-SI) The scope of prefixes is fairly wide (Pico- to Exa- for Becquerel , Pico- to Tera- for Curie and Rutherford) in order to support most common scenarios, like measuring concentration of radioactive elements in a substance (e.g. 10 Bq per m3 of air is considered normal), rate of radioactive decay in electrical parts, Geiger counter scales, cosmic ray interactions or even global inventory of specific radioactive elements (per [Wikipedia](https://en.wikipedia.org/wiki/Becquerel#Examples)). It does not, however, support prefixes for things like activity produced by [nuclear explosions](https://books.google.pl/books?id=CJqcq2C792UC&pg=PA74&redir_esc=y#v=onepage&q=hiroshima&f=false) (values beyond 10^24 Bq), since this seems too niche even for C# devs. Similar PR was already created a quople years back (#915), but it was never actually merged. --------- Co-authored-by: Piotr Stenke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Si unit for radioactivity is the Becquerel (Bq) which is one disintegration per second. The non-SI unit is the Curie (Ci) where 1 Curie = 3.7e10 Becquerel